* [PATCH 1/7] megaraid_sas : Driver version upgrade
@ 2014-11-10 12:21 Sumit.Saxena
2014-11-11 13:44 ` Tomas Henzl
0 siblings, 1 reply; 4+ messages in thread
From: Sumit.Saxena @ 2014-11-10 12:21 UTC (permalink / raw)
To: linux-scsi; +Cc: martin.petersen, hch, jbottomley, kashyap.desai, aradford
megaraid_sas driver version upgrade
Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 2 +-
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index a49914d..f3eccf1 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -33,7 +33,7 @@
/*
* MegaRAID SAS Driver meta data
*/
-#define MEGASAS_VERSION "06.805.06.00-rc1"
+#define MEGASAS_VERSION "06.805.06.01-rc1"
#define MEGASAS_RELDATE "Sep. 4, 2014"
#define MEGASAS_EXT_VERSION "Thu. Sep. 4 17:00:00 PDT 2014"
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index f6a69a3..36f463c 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -18,7 +18,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
* FILE: megaraid_sas_base.c
- * Version : 06.805.06.00-rc1
+ * Version : 06.805.06.01-rc1
*
* Authors: LSI Corporation
* Sreenivas Bagalkote
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/7] megaraid_sas : Driver version upgrade
2014-11-10 12:21 [PATCH 1/7] megaraid_sas : Driver version upgrade Sumit.Saxena
@ 2014-11-11 13:44 ` Tomas Henzl
2014-11-12 11:13 ` Kashyap Desai
0 siblings, 1 reply; 4+ messages in thread
From: Tomas Henzl @ 2014-11-11 13:44 UTC (permalink / raw)
To: Sumit.Saxena, linux-scsi
Cc: martin.petersen, hch, jbottomley, kashyap.desai, aradford
On 11/10/2014 01:21 PM, Sumit.Saxena@avagotech.com wrote:
> megaraid_sas driver version upgrade
>
> Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 2 +-
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
> index a49914d..f3eccf1 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -33,7 +33,7 @@
> /*
> * MegaRAID SAS Driver meta data
> */
> -#define MEGASAS_VERSION "06.805.06.00-rc1"
> +#define MEGASAS_VERSION "06.805.06.01-rc1"
> #define MEGASAS_RELDATE "Sep. 4, 2014"
> #define MEGASAS_EXT_VERSION "Thu. Sep. 4 17:00:00 PDT 2014"
Usually you have changed the dates too, but this not important, feel free to ignore it.
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index f6a69a3..36f463c 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -18,7 +18,7 @@
> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> *
> * FILE: megaraid_sas_base.c
> - * Version : 06.805.06.00-rc1
> + * Version : 06.805.06.01-rc1
> *
> * Authors: LSI Corporation
> * Sreenivas Bagalkote
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/7] megaraid_sas : Driver version upgrade
2014-11-11 13:44 ` Tomas Henzl
@ 2014-11-12 11:13 ` Kashyap Desai
2014-11-12 13:52 ` Tomas Henzl
0 siblings, 1 reply; 4+ messages in thread
From: Kashyap Desai @ 2014-11-12 11:13 UTC (permalink / raw)
To: Tomas Henzl, Sumit Saxena, linux-scsi
Cc: martin.petersen, hch, jbottomley, aradford
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Tuesday, November 11, 2014 7:14 PM
> To: Sumit.Saxena@avagotech.com; linux-scsi@vger.kernel.org
> Cc: martin.petersen@oracle.com; hch@infradead.org;
> jbottomley@parallels.com; kashyap.desai@avagotech.com;
> aradford@gmail.com
> Subject: Re: [PATCH 1/7] megaraid_sas : Driver version upgrade
>
> On 11/10/2014 01:21 PM, Sumit.Saxena@avagotech.com wrote:
> > megaraid_sas driver version upgrade
> >
> > Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
> > ---
> > drivers/scsi/megaraid/megaraid_sas.h | 2 +-
> > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/megaraid/megaraid_sas.h
> b/drivers/scsi/megaraid/megaraid_sas.h
> > index a49914d..f3eccf1 100644
> > --- a/drivers/scsi/megaraid/megaraid_sas.h
> > +++ b/drivers/scsi/megaraid/megaraid_sas.h
> > @@ -33,7 +33,7 @@
> > /*
> > * MegaRAID SAS Driver meta data
> > */
> > -#define MEGASAS_VERSION "06.805.06.00-
> rc1"
> > +#define MEGASAS_VERSION "06.805.06.01-
> rc1"
> > #define MEGASAS_RELDATE "Sep. 4, 2014"
> > #define MEGASAS_EXT_VERSION "Thu. Sep. 4
17:00:00
> PDT 2014"
>
> Usually you have changed the dates too, but this not important, feel
free to
> ignore it.
Agree that we always keep version/date sync-up in same patch.
I think having RELDATE is not really helpful and I see only megaraid_sas
driver use this.
Probably we should keep only VERSION and remove RELDATE and EXT_VERSION
>
> >
> > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> > index f6a69a3..36f463c 100644
> > --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> > @@ -18,7 +18,7 @@
> > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307
> USA
> > *
> > * FILE: megaraid_sas_base.c
> > - * Version : 06.805.06.00-rc1
> > + * Version : 06.805.06.01-rc1
> > *
> > * Authors: LSI Corporation
> > * Sreenivas Bagalkote
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/7] megaraid_sas : Driver version upgrade
2014-11-12 11:13 ` Kashyap Desai
@ 2014-11-12 13:52 ` Tomas Henzl
0 siblings, 0 replies; 4+ messages in thread
From: Tomas Henzl @ 2014-11-12 13:52 UTC (permalink / raw)
To: Kashyap Desai, Sumit Saxena, linux-scsi
Cc: martin.petersen, hch, jbottomley, aradford
On 11/12/2014 12:13 PM, Kashyap Desai wrote:
>> -----Original Message-----
>> From: Tomas Henzl [mailto:thenzl@redhat.com]
>> Sent: Tuesday, November 11, 2014 7:14 PM
>> To: Sumit.Saxena@avagotech.com; linux-scsi@vger.kernel.org
>> Cc: martin.petersen@oracle.com; hch@infradead.org;
>> jbottomley@parallels.com; kashyap.desai@avagotech.com;
>> aradford@gmail.com
>> Subject: Re: [PATCH 1/7] megaraid_sas : Driver version upgrade
>>
>> On 11/10/2014 01:21 PM, Sumit.Saxena@avagotech.com wrote:
>>> megaraid_sas driver version upgrade
>>>
>>> Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
>>> ---
>>> drivers/scsi/megaraid/megaraid_sas.h | 2 +-
>>> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
>> b/drivers/scsi/megaraid/megaraid_sas.h
>>> index a49914d..f3eccf1 100644
>>> --- a/drivers/scsi/megaraid/megaraid_sas.h
>>> +++ b/drivers/scsi/megaraid/megaraid_sas.h
>>> @@ -33,7 +33,7 @@
>>> /*
>>> * MegaRAID SAS Driver meta data
>>> */
>>> -#define MEGASAS_VERSION "06.805.06.00-
>> rc1"
>>> +#define MEGASAS_VERSION "06.805.06.01-
>> rc1"
>>> #define MEGASAS_RELDATE "Sep. 4, 2014"
>>> #define MEGASAS_EXT_VERSION "Thu. Sep. 4
> 17:00:00
>> PDT 2014"
>>
>> Usually you have changed the dates too, but this not important, feel
> free to
>> ignore it.
> Agree that we always keep version/date sync-up in same patch.
> I think having RELDATE is not really helpful and I see only megaraid_sas
> driver use this.
>
> Probably we should keep only VERSION and remove RELDATE and EXT_VERSION
EXT_VERSION is used to print a message to log - you can change it as you wish,
I haven't noticed something similar to RELDATE in other drivers, so again
I've no problem with any change.
>
>>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>> b/drivers/scsi/megaraid/megaraid_sas_base.c
>>> index f6a69a3..36f463c 100644
>>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
>>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>>> @@ -18,7 +18,7 @@
>>> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> 02111-1307
>> USA
>>> *
>>> * FILE: megaraid_sas_base.c
>>> - * Version : 06.805.06.00-rc1
>>> + * Version : 06.805.06.01-rc1
>>> *
>>> * Authors: LSI Corporation
>>> * Sreenivas Bagalkote
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-12 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-10 12:21 [PATCH 1/7] megaraid_sas : Driver version upgrade Sumit.Saxena
2014-11-11 13:44 ` Tomas Henzl
2014-11-12 11:13 ` Kashyap Desai
2014-11-12 13:52 ` Tomas Henzl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).