From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 05/11] scsi: remove abuses of scsi_populate_tag Date: Tue, 11 Nov 2014 16:39:28 +0100 Message-ID: <54622DB0.50004@suse.de> References: <1415634990-3023-1-git-send-email-hch@lst.de> <1415634990-3023-6-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:43744 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbaKKPja (ORCPT ); Tue, 11 Nov 2014 10:39:30 -0500 In-Reply-To: <1415634990-3023-6-git-send-email-hch@lst.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig , linux-scsi@vger.kernel.org Cc: James Bottomley , Robert Elliott , "Martin K. Petersen" , Bart van Assche , Jens Axboe , Kashyap Desai , Sreekanth Reddy , Mike Christie , Guennadi Liakhovetski , usb-storage@lists.one-eyed-alien.net On 11/10/2014 04:56 PM, Christoph Hellwig wrote: > Unless we want to build a SPI tag message we should just check SCMD_T= AGGED > instead of reverse engineering a tag type through the use of > scsi_populate_tag_msg. >=20 > Also rename the function to spi_populate_tag_msg, make it behave like= the > other spi message helpers, and move it to the spi transport class. >=20 > Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 21284 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html