From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 11/11] ufs: remove spurious scsi_set_tag_type call Date: Tue, 11 Nov 2014 16:42:31 +0100 Message-ID: <54622E67.3020900@suse.de> References: <1415634990-3023-1-git-send-email-hch@lst.de> <1415634990-3023-12-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:43848 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbaKKPmd (ORCPT ); Tue, 11 Nov 2014 10:42:33 -0500 In-Reply-To: <1415634990-3023-12-git-send-email-hch@lst.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig , linux-scsi@vger.kernel.org Cc: James Bottomley , Robert Elliott , "Martin K. Petersen" , Bart van Assche , Jens Axboe , Kashyap Desai , Sreekanth Reddy , Mike Christie , Guennadi Liakhovetski , usb-storage@lists.one-eyed-alien.net On 11/10/2014 04:56 PM, Christoph Hellwig wrote: > ufs never looks at the tag type, so there is no need to set it either= =2E >=20 > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/ufs/ufshcd.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 67e2280..362b818 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -2768,7 +2768,6 @@ static int ufshcd_slave_alloc(struct scsi_devic= e *sdev) > =20 > /* Mode sense(6) is not supported by UFS, so use Mode sense(10) */ > sdev->use_10_for_ms =3D 1; > - scsi_set_tag_type(sdev, MSG_SIMPLE_TAG); > =20 > /* allow SCSI layer to restart the device in case of errors */ > sdev->allow_restart =3D 1; >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 21284 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html