From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 2/6] scsi: remove scsi_next_command
Date: Tue, 11 Nov 2014 20:02:46 +0100 [thread overview]
Message-ID: <54625D56.20308@suse.de> (raw)
In-Reply-To: <20141111163748.GA13445@lst.de>
On 11/11/2014 05:37 PM, Christoph Hellwig wrote:
> On Thu, Nov 06, 2014 at 04:34:13PM +0100, Christoph Hellwig wrote:
>> On Thu, Nov 06, 2014 at 09:21:05AM +0100, Hannes Reinecke wrote:
>>> Hmm? Isn't there a scsi_put_comand() too many?
>>> You dropped it from the 'if' branch, moved it out of
>>> the condition, but kept in in the 'else' branch ...
>>
>> The put_device for the 'else' branch was hidden inside scsi_next_command.
>
> Is this a good enough explanation to get a Reviewed-by?
>
Yep.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-11 19:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 7:40 I/O path cleanup V2 Christoph Hellwig
2014-11-06 7:40 ` [PATCH 1/6] scsi: don't use scsi_next_command in scsi_reset_provider Christoph Hellwig
2014-11-06 8:18 ` Hannes Reinecke
2014-11-06 7:40 ` [PATCH 2/6] scsi: remove scsi_next_command Christoph Hellwig
2014-11-06 8:21 ` Hannes Reinecke
2014-11-06 15:34 ` Christoph Hellwig
2014-11-11 16:37 ` Christoph Hellwig
2014-11-11 19:02 ` Hannes Reinecke [this message]
2014-11-06 7:40 ` [PATCH 3/6] scsi: clean up S/G table freeing Christoph Hellwig
2014-11-06 8:23 ` Hannes Reinecke
2014-11-18 18:14 ` Bart Van Assche
2014-11-20 8:16 ` Christoph Hellwig
2014-11-06 7:40 ` [PATCH 4/6] scsi: stop passing a gfp_mask argument down the command setup path Christoph Hellwig
2014-11-06 8:24 ` Hannes Reinecke
2014-11-06 7:40 ` [PATCH 5/6] scsi: move scsi_dispatch_cmd to scsi_lib.c Christoph Hellwig
2014-11-06 8:25 ` Hannes Reinecke
2014-11-06 7:40 ` [PATCH 6/6] scsi: move more requeue handling into scsi_requeue_command Christoph Hellwig
2014-11-06 8:26 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54625D56.20308@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).