From: Mike Christie <michaelc@cs.wisc.edu>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org, James Smart <james.smart@emulex.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: split ->change_queue_depth
Date: Sun, 23 Nov 2014 23:51:55 -0600 [thread overview]
Message-ID: <5472C77B.1020401@cs.wisc.edu> (raw)
In-Reply-To: <1415901546-8006-1-git-send-email-hch@lst.de>
On 11/13/14, 11:58 AM, Christoph Hellwig wrote:
> Overloading ->change_queue_depth with the queue ramp up / down
> functionality has been a bad idea. It lead to a large amount
> of code duplication, and driver keep getting the the API
> wrong and end up accidentally enabling the queue depth tracking
> while getting it wrong.
>
> This serie instead adds a flag to enable queue tracking and
> handles it entirely in core code. This is a preparation for
> various logic changes to the queue depth tracking code.
>
Looks nice to me.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2014-11-24 5:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 17:58 split ->change_queue_depth Christoph Hellwig
2014-11-13 17:59 ` [PATCH 1/7] lpfc: remove queue_depth events Christoph Hellwig
2014-11-20 7:27 ` Hannes Reinecke
2014-11-20 19:16 ` James Smart
2014-11-21 10:20 ` Christoph Hellwig
2014-11-13 17:59 ` [PATCH 2/7] scsi: avoid ->change_queue_depth indirection for queue full tracking Christoph Hellwig
2014-11-13 19:47 ` venkateshs
2014-11-21 10:19 ` Christoph Hellwig
2014-11-20 7:34 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 3/7] scsi: don't allow setting of queue_depth bigger than can_queue Christoph Hellwig
2014-11-20 7:35 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 4/7] scsi: drop reason argument from ->change_queue_depth Christoph Hellwig
2014-11-20 7:39 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 5/7] mpt2sas: simplify ->change_queue_depth Christoph Hellwig
2014-11-20 7:39 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 6/7] mpt3sas: " Christoph Hellwig
2014-11-20 7:40 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 7/7] vmw_pscsi: " Christoph Hellwig
2014-11-20 7:40 ` Hannes Reinecke
2014-11-20 6:13 ` split ->change_queue_depth Christoph Hellwig
2014-11-24 5:51 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5472C77B.1020401@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@lst.de \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).