[PATCH] scsi_debug: improve driver description in Kconfig

[PATCH] scsi_debug: improve driver description in Kconfig

[Douglas Gilbert]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

From: Douglas Gilbert <dgilbert@interlog.com>
Date: Wed, 26 Nov 2014 14:41:55 -0500
Subject: [PATCH] scsi_debug improve driver description in Kconfig

Try to give a more accurate driver description and some extra
useful information in less lines.
---
  drivers/scsi/Kconfig | 17 ++++++++---------
  1 file changed, 8 insertions(+), 9 deletions(-)

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>


[-- Attachment #2: 0001-scsi_debug-improve-driver-description-in-Kconfig.patch --]
[-- Type: text/x-patch, Size: 1885 bytes --]

>From a9a36335e3983eaa229fa4c1d79253977eed9dc6 Mon Sep 17 00:00:00 2001
From: Douglas Gilbert <dgilbert@interlog.com>
Date: Wed, 26 Nov 2014 14:41:55 -0500
Subject: [PATCH] scsi_debug improve driver description in Kconfig

Try to give a more accurate driver description and some extra
useful information in less lines.
---
 drivers/scsi/Kconfig | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 86cf3d6..2e3a661 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1462,18 +1462,17 @@ config SCSI_WD719X
 	  SCSI controllers (based on WD33C296A chip).
 
 config SCSI_DEBUG
-	tristate "SCSI debugging host simulator"
+	tristate "SCSI debugging host and device simulator"
 	depends on SCSI
 	select CRC_T10DIF
 	help
-	  This is a host adapter simulator that can simulate multiple hosts
-	  each with multiple dummy SCSI devices (disks). It defaults to one
-	  host adapter with one dummy SCSI disk. Each dummy disk uses kernel
-	  RAM as storage (i.e. it is a ramdisk). To save space when multiple
-	  dummy disks are simulated, they share the same kernel RAM for 
-	  their storage. See <http://sg.danny.cz/sg/sdebug26.html> for more
-	  information. This driver is primarily of use to those testing the
-	  SCSI and block subsystems. If unsure, say N.
+	  This pseudo driver simulates one or more hosts (SCSI initiators),
+	  each with one or more targets, each with one or more logical units.
+	  Defaults to one of each, creating a small ram disk device. Many
+	  parameters found in the /sys/bus/pseudo/drivers/scsi_debug
+	  directory can be tweaked at run time.
+	  See <http://sg.danny.cz/sg/sdebug26.html> for more information.
+	  Mainly used for testing and best as a module. If unsure, say N.
 
 config SCSI_MESH
 	tristate "MESH (Power Mac internal SCSI) support"
-- 
1.9.1

Re: [PATCH] scsi_debug: improve driver description in Kconfig

[Randy Dunlap]

On 11/26/14 11:55, Douglas Gilbert wrote:
> From: Douglas Gilbert <dgilbert@interlog.com>
> Date: Wed, 26 Nov 2014 14:41:55 -0500
> Subject: [PATCH] scsi_debug improve driver description in Kconfig
> 
> Try to give a more accurate driver description and some extra
> useful information in less lines.
> ---
>  drivers/scsi/Kconfig | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
> 

creating a small ram disk device.

I would say:     RAM

Otherwise looks good to me.

-- 
~Randy

Re: [PATCH] scsi_debug: improve driver description in Kconfig

[Douglas Gilbert]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

On 14-11-28 04:05 PM, Randy Dunlap wrote:
> On 11/26/14 11:55, Douglas Gilbert wrote:
>> From: Douglas Gilbert <dgilbert@interlog.com>
>> Date: Wed, 26 Nov 2014 14:41:55 -0500
>> Subject: [PATCH] scsi_debug improve driver description in Kconfig
>>
>> Try to give a more accurate driver description and some extra
>> useful information in less lines.
>> ---
>>   drivers/scsi/Kconfig | 17 ++++++++---------
>>   1 file changed, 8 insertions(+), 9 deletions(-)
>>
>> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
>>
>
> creating a small ram disk device.
>
> I would say:     RAM
>
> Otherwise looks good to me.

Okay, version 2 attached.

From: Douglas Gilbert <dgilbert@interlog.com>
Date: Fri, 28 Nov 2014 19:03:21 -0500
Subject: [PATCH] scsi_debug improve driver description in Kconfig

Try to give a more accurate driver description and some extra
information in less lines.
---
  drivers/scsi/Kconfig | 17 ++++++++---------
  1 file changed, 8 insertions(+), 9 deletions(-)

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>


[-- Attachment #2: 0001-scsi_debug-improve-driver-description-in-Kconfig-v2.patch --]
[-- Type: text/x-patch, Size: 1878 bytes --]

>From 9d735409215bb44fdec1dcf0cbe4acf7bd05021f Mon Sep 17 00:00:00 2001
From: Douglas Gilbert <dgilbert@interlog.com>
Date: Fri, 28 Nov 2014 19:03:21 -0500
Subject: [PATCH] scsi_debug improve driver description in Kconfig

Try to give a more accurate driver description and some extra
information in less lines.
---
 drivers/scsi/Kconfig | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 86cf3d6..9c92f41 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1462,18 +1462,17 @@ config SCSI_WD719X
 	  SCSI controllers (based on WD33C296A chip).
 
 config SCSI_DEBUG
-	tristate "SCSI debugging host simulator"
+	tristate "SCSI debugging host and device simulator"
 	depends on SCSI
 	select CRC_T10DIF
 	help
-	  This is a host adapter simulator that can simulate multiple hosts
-	  each with multiple dummy SCSI devices (disks). It defaults to one
-	  host adapter with one dummy SCSI disk. Each dummy disk uses kernel
-	  RAM as storage (i.e. it is a ramdisk). To save space when multiple
-	  dummy disks are simulated, they share the same kernel RAM for 
-	  their storage. See <http://sg.danny.cz/sg/sdebug26.html> for more
-	  information. This driver is primarily of use to those testing the
-	  SCSI and block subsystems. If unsure, say N.
+	  This pseudo driver simulates one or more hosts (SCSI initiators),
+	  each with one or more targets, each with one or more logical units.
+	  Defaults to one of each, creating a small RAM disk device. Many
+	  parameters found in the /sys/bus/pseudo/drivers/scsi_debug
+	  directory can be tweaked at run time.
+	  See <http://sg.danny.cz/sg/sdebug26.html> for more information.
+	  Mainly used for testing and best as a module. If unsure, say N.
 
 config SCSI_MESH
 	tristate "MESH (Power Mac internal SCSI) support"
-- 
1.9.1

Re: [PATCH] scsi_debug: improve driver description in Kconfig

[Ewan Milne]

On Wed, 2014-11-26 at 14:55 -0500, Douglas Gilbert wrote:
> From: Douglas Gilbert <dgilbert@interlog.com>
> Date: Wed, 26 Nov 2014 14:41:55 -0500
> Subject: [PATCH] scsi_debug improve driver description in Kconfig
> 
> Try to give a more accurate driver description and some extra
> useful information in less lines.
> ---
>   drivers/scsi/Kconfig | 17 ++++++++---------
>   1 file changed, 8 insertions(+), 9 deletions(-)
> 
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
> 

Reviewed-by: Ewan D. Milne <emilne@redhat.com>

Re: [PATCH] scsi_debug: improve driver description in Kconfig

[Christoph Hellwig]

Thanks, applied to drivers-for-3.19.