From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Cc: Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH 2/4] scsi: never drop to untagged mode during queue ramp down
Date: Fri, 28 Nov 2014 10:59:53 +0100 [thread overview]
Message-ID: <54784799.80704@acm.org> (raw)
In-Reply-To: <1416839781-26988-3-git-send-email-hch@lst.de>
On 11/24/14 15:36, Christoph Hellwig wrote:
> Dropping to untagged mode when ramping down a queue due to QUEUE FULL
> events has two problems:
>
> - nothing in the midlayer or drivers ever moves back to tagged mode
> during queue ramp up.
> - cmd_per_lun isn't the untagged queue depth for many modern drivers
> that can handle multiple untagged commands, and this is the only
> place in the midlayer assuming that.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2014-11-28 10:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 14:36 queue_type fixups Christoph Hellwig
2014-11-24 14:36 ` [PATCH 1/4] scsi: remove ->change_queue_type method Christoph Hellwig
2014-11-28 9:59 ` Bart Van Assche
2014-12-03 13:32 ` Hannes Reinecke
2014-12-04 9:10 ` Christoph Hellwig
2014-12-04 2:27 ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 2/4] scsi: never drop to untagged mode during queue ramp down Christoph Hellwig
2014-11-28 9:59 ` Bart Van Assche [this message]
2014-12-03 13:32 ` Hannes Reinecke
2014-12-04 2:28 ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 3/4] scsi: remove scsi_get_tag_type Christoph Hellwig
2014-11-28 10:00 ` Bart Van Assche
2014-12-03 13:33 ` Hannes Reinecke
2014-12-04 2:28 ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 4/4] scsi: remove scsi_set_tag_type Christoph Hellwig
2014-11-28 10:00 ` Bart Van Assche
2014-12-03 13:34 ` Hannes Reinecke
2014-12-04 2:29 ` Martin K. Petersen
2014-11-24 15:07 ` [PATCH 5/4] scsi: remove MSG_*_TAG defines Christoph Hellwig
2014-11-28 9:58 ` Bart Van Assche
2014-12-01 9:03 ` Christoph Hellwig
2014-12-01 11:44 ` Bart Van Assche
2014-12-04 2:31 ` Martin K. Petersen
2014-12-03 9:32 ` queue_type fixups Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54784799.80704@acm.org \
--to=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).