From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH 5/4] scsi: remove MSG_*_TAG defines
Date: Mon, 01 Dec 2014 12:44:23 +0100 [thread overview]
Message-ID: <547C5497.5020706@acm.org> (raw)
In-Reply-To: <20141201090315.GA4042@infradead.org>
On 12/01/14 10:03, Christoph Hellwig wrote:
> On Fri, Nov 28, 2014 at 10:58:58AM +0100, Bart Van Assche wrote:
>>> if (disable_syn_offset_one_fix) {
>>> - scsiq->q2.tag_code &= ~MSG_SIMPLE_TAG;
>>> + scsiq->q2.tag_code &= ~SIMPLE_QUEUE_TAG;
>>> scsiq->q2.tag_code |= (ASC_TAG_FLAG_DISABLE_ASYN_USE_SYN_FIX |
>>> ASC_TAG_FLAG_DISABLE_DISCONNECT);
>>> } else {
>>
>> One of the statements in advansys.c (tag_code &= 0xDC) makes assumptions
>> about the numeric value of MSG_SIMPLE_TAG. This makes me wonder whether it
>> is safe to change MSG_SIMPLE_TAG into another value ?
>
> MSG_SIMPLE_TAG and SIMPLE_QUEUE_TAG are two different symbolic names
> for the 0x20 value assigned to the SCSI-2 protocol "SIMPLE QUEUE TAG"
> message. Having both is confusing, so I decided to only keep the one
> that is named closer to the spec, and in the same namespace as the
> symbolic names we use for other SCSI-2 messages.
Thanks for the clarification. Using different namespaces for symbolic
constants for initiator and target drivers definitely looks like a good
idea to me. The patch itself also looks fine to me. Hence:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2014-12-01 11:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 14:36 queue_type fixups Christoph Hellwig
2014-11-24 14:36 ` [PATCH 1/4] scsi: remove ->change_queue_type method Christoph Hellwig
2014-11-28 9:59 ` Bart Van Assche
2014-12-03 13:32 ` Hannes Reinecke
2014-12-04 9:10 ` Christoph Hellwig
2014-12-04 2:27 ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 2/4] scsi: never drop to untagged mode during queue ramp down Christoph Hellwig
2014-11-28 9:59 ` Bart Van Assche
2014-12-03 13:32 ` Hannes Reinecke
2014-12-04 2:28 ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 3/4] scsi: remove scsi_get_tag_type Christoph Hellwig
2014-11-28 10:00 ` Bart Van Assche
2014-12-03 13:33 ` Hannes Reinecke
2014-12-04 2:28 ` Martin K. Petersen
2014-11-24 14:36 ` [PATCH 4/4] scsi: remove scsi_set_tag_type Christoph Hellwig
2014-11-28 10:00 ` Bart Van Assche
2014-12-03 13:34 ` Hannes Reinecke
2014-12-04 2:29 ` Martin K. Petersen
2014-11-24 15:07 ` [PATCH 5/4] scsi: remove MSG_*_TAG defines Christoph Hellwig
2014-11-28 9:58 ` Bart Van Assche
2014-12-01 9:03 ` Christoph Hellwig
2014-12-01 11:44 ` Bart Van Assche [this message]
2014-12-04 2:31 ` Martin K. Petersen
2014-12-03 9:32 ` queue_type fixups Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C5497.5020706@acm.org \
--to=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).