From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] fc: FCP_PTA_SIMPLE is 0
Date: Wed, 03 Dec 2014 15:09:42 +0100 [thread overview]
Message-ID: <547F19A6.3010000@suse.de> (raw)
In-Reply-To: <1416927010-6036-1-git-send-email-hch@lst.de>
On 11/25/2014 03:50 PM, Christoph Hellwig wrote:
> Not need to have an if/else to either assign FCP_PTA_SIMPLE or 0
> to a variable.
>
> Btw, it seems we really should factor generating a fcp cmnd from
> a scsi_cmnd into a common helper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-03 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 14:50 [PATCH 1/2] fc: FCP_PTA_SIMPLE is 0 Christoph Hellwig
2014-11-25 14:50 ` [PATCH 2/2] ibmvfc: remove unused tag variable Christoph Hellwig
2014-12-03 14:10 ` Hannes Reinecke
2014-12-03 14:36 ` Brian King
2014-12-04 2:24 ` Martin K. Petersen
2014-12-03 9:31 ` [PATCH 1/2] fc: FCP_PTA_SIMPLE is 0 Christoph Hellwig
2014-12-03 14:09 ` Hannes Reinecke [this message]
2014-12-04 2:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F19A6.3010000@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).