* [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays
@ 2014-12-02 18:47 Brian King
2014-12-02 21:25 ` wenxiong
2014-12-04 9:25 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Brian King @ 2014-12-02 18:47 UTC (permalink / raw)
To: James.Bottomley; +Cc: hch, linux-scsi, wenxiong, anton, brking
Set the scsi_level correctly for disk arrays such
that things like the rotational field get set
properly by sd.c.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 1 +
1 file changed, 1 insertion(+)
diff -puN drivers/scsi/ipr.c~ipr_array_scsi_level drivers/scsi/ipr.c
--- scsi-queue/drivers/scsi/ipr.c~ipr_array_scsi_level 2014-12-02 12:13:28.585275691 -0600
+++ scsi-queue-bjking1/drivers/scsi/ipr.c 2014-12-02 12:13:28.591275641 -0600
@@ -4740,6 +4740,7 @@ static int ipr_slave_configure(struct sc
sdev->no_uld_attach = 1;
}
if (ipr_is_vset_device(res)) {
+ sdev->scsi_level = SCSI_SPC_3;
blk_queue_rq_timeout(sdev->request_queue,
IPR_VSET_RW_TIMEOUT);
blk_queue_max_hw_sectors(sdev->request_queue, IPR_VSET_MAX_SECTORS);
_
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays
2014-12-02 18:47 [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays Brian King
@ 2014-12-02 21:25 ` wenxiong
2014-12-04 9:25 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: wenxiong @ 2014-12-02 21:25 UTC (permalink / raw)
To: Brian King; +Cc: James.Bottomley, hch, linux-scsi, anton
Reviewed-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
Thanks,
Wendy
Quoting Brian King <brking@linux.vnet.ibm.com>:
> Set the scsi_level correctly for disk arrays such
> that things like the rotational field get set
> properly by sd.c.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
>
> drivers/scsi/ipr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -puN drivers/scsi/ipr.c~ipr_array_scsi_level drivers/scsi/ipr.c
> --- scsi-queue/drivers/scsi/ipr.c~ipr_array_scsi_level 2014-12-02
> 12:13:28.585275691 -0600
> +++ scsi-queue-bjking1/drivers/scsi/ipr.c 2014-12-02 12:13:28.591275641 -0600
> @@ -4740,6 +4740,7 @@ static int ipr_slave_configure(struct sc
> sdev->no_uld_attach = 1;
> }
> if (ipr_is_vset_device(res)) {
> + sdev->scsi_level = SCSI_SPC_3;
> blk_queue_rq_timeout(sdev->request_queue,
> IPR_VSET_RW_TIMEOUT);
> blk_queue_max_hw_sectors(sdev->request_queue, IPR_VSET_MAX_SECTORS);
> _
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays
2014-12-02 18:47 [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays Brian King
2014-12-02 21:25 ` wenxiong
@ 2014-12-04 9:25 ` Christoph Hellwig
2014-12-04 16:10 ` Brian King
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2014-12-04 9:25 UTC (permalink / raw)
To: Brian King; +Cc: James.Bottomley, hch, linux-scsi, wenxiong, anton
Do you want me to apply this patch ASAP while waiting for the kexec ACK?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays
2014-12-04 9:25 ` Christoph Hellwig
@ 2014-12-04 16:10 ` Brian King
2014-12-15 13:46 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Brian King @ 2014-12-04 16:10 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: James.Bottomley, linux-scsi, wenxiong, anton
On 12/04/2014 03:25 AM, Christoph Hellwig wrote:
> Do you want me to apply this patch ASAP while waiting for the kexec ACK?
Both patches 1 and 4 can be pulled in while we wait for Eric's ack.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays
2014-12-04 16:10 ` Brian King
@ 2014-12-15 13:46 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2014-12-15 13:46 UTC (permalink / raw)
To: Brian King
Cc: Christoph Hellwig, James.Bottomley, linux-scsi, wenxiong, anton
On Thu, Dec 04, 2014 at 10:10:49AM -0600, Brian King wrote:
> On 12/04/2014 03:25 AM, Christoph Hellwig wrote:
> > Do you want me to apply this patch ASAP while waiting for the kexec ACK?
>
> Both patches 1 and 4 can be pulled in while we wait for Eric's ack.
I've applied patches 1 and 4 to drivers-for-3.19.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-15 13:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-02 18:47 [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays Brian King
2014-12-02 21:25 ` wenxiong
2014-12-04 9:25 ` Christoph Hellwig
2014-12-04 16:10 ` Brian King
2014-12-15 13:46 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).