linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, stable@vger.kernel.org.#.v3.10+
Subject: Re: [PATCH 2/4] [SCSI] Blacklist RSOC for Microsoft iSCSI target devices
Date: Thu, 04 Dec 2014 19:24:39 -0600	[thread overview]
Message-ID: <54810957.8080706@cs.wisc.edu> (raw)
In-Reply-To: <1417659492-2679-2-git-send-email-martin.petersen@oracle.com>

On 12/3/14, 8:18 PM, Martin K. Petersen wrote:
> The Microsoft iSCSI target does not support REPORT SUPPORTED OPERATION
> CODES. Blacklist these devices so we don't attempt to send the command.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reported-by: jazz@deti74.ru
> Cc: Mike Christie <michaelc@cs.wisc.edu>
> Cc: stable@vger.kernel.org # v3.10+
> ---
>   drivers/scsi/scsi_devinfo.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index 8c228e049bb6..db42c37e1230 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -210,6 +210,7 @@ static struct {
>   	{"Medion", "Flash XL  MMC/SD", "2.6D", BLIST_FORCELUN},
>   	{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
>   	{"MICROP", "4110", NULL, BLIST_NOTQ},
> +	{"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
>   	{"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
>   	{"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
>   	{"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
>

Thanks Martin.

Tested-by: Mike Christie <michaelc@cs.wisc.edu>

In case other people test this patch, I wanted to warn people that the 
MS iSCSI target does the same sequence (sends reject PDU then drops the 
connection on us) for any command it does not support. We end up seeing 
the same problem for other commands. For example, some distros have 
tools that send CDB 0x85 during initialization, and the MS target will 
fail on that in the same way we saw here.

  reply	other threads:[~2014-12-05  1:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  2:18 [PATCH 1/4] [SCSI] Only blacklist WRITE SAME for VMware virtual disks Martin K. Petersen
2014-12-04  2:18 ` [PATCH 2/4] [SCSI] Blacklist RSOC for Microsoft iSCSI target devices Martin K. Petersen
2014-12-05  1:24   ` Mike Christie [this message]
2014-12-05  2:17     ` Martin K. Petersen
2014-12-05 16:59       ` Mike Christie
2014-12-15 13:47   ` Christoph Hellwig
2014-12-04  2:18 ` [PATCH 3/4] [SCSI] sd: Sanity check the optimal I/O size Martin K. Petersen
2014-12-04  2:18 ` [PATCH 4/4] [SCSI] Remove VPD quirk for Seagate drives Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54810957.8080706@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stable@vger.kernel.org.#.v3.10+ \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).