Re: [PATCH repost 3] [SCSI] Retrieve the Caching mode page

Matthew Wilcox
2010-12-08T16:00:28Z

On Wed, Dec 08, 2010 at 10:57:46AM -0500, Alan Stern wrote:
> In the strictest sense, there's always a possibility that any change
> will crash _some_ device somewhere. In this case I believe the
> probability is very low. Luben's patch does not change the commands
> sent to a USB device; it only changes the kernel's interpretation of
> the data sent back. Unless things are terribly badly broken, this
> won't hurt.

It doesn't change the _discovery_ commands sent to the device, but (I
think ...) it will change the subsequent commands sent to the device;
eg we'll now send it SYNCHRONISE CACHE when we wouldn't have before.
I think it's low-risk too, and am in favour of seeing this patch applied.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."