Re: [PATCH repost 3] [SCSI] Retrieve the Caching mode page

James Bottomley
2010-12-08T15:43:41Z

On Wed, 2010-12-08 at 10:16 -0500, Alan Stern wrote:
> On Tue, 7 Dec 2010, James Bottomley wrote:
>
> > Well, not other than I've already said: I think it looks OK, so I
> > marked it for my merge window queue. I'd still rather like USB people
> > to confirm that the original reason why this was done (to prevent device
> > crashes on the mode sense) is no longer an issue
>
> The original reason for adding the skip_ms_page_8 flag still applies.
> To assume it is no longer an issue would not be safe -- there's no
> reason to believe that the buggy devices it was meant for have all been
> retired.
>
> > ... but it's only USB
> > stuff, so suppose I'm OK with finding out in the field.
>
> With USB there's often no other choice.

So the translation is that there's a possibility it will crash USB
devices but the only way to find out is to release it and see.

My problem is that it only takes one bug report from one failing device
(which I'm sure some kind soul will dig out of the attic or wherever
they threw it) for this to be a regression and then I get to revert the
patch ... unless we have a working backup plan?

I think it's easy to put in and easy to revert ... we'll pick up a bit
of flack if the failing device doesn't appear for some time, but I'm OK
with risking that.

James