Re: [PATCH 08/17] ibmvscsi: Fix bidi command test

[Tyrel Datwyler <tyreld@linux.vnet.ibm.com>]

On 01/27/2015 11:57 PM, Bart Van Assche wrote:

[snip]

> 
> Hello Tyrel,
> 
> Since the ibmvscsi driver does not set QUEUE_FLAG_BIDI neither the code
> under "case DMA_BIDIRECTIONAL" nor the code under "if
> (scsi_bidi_cmnd(cmd))" is ever executed. The only reason why I proposed
> this change is to avoid that an author of another SCSI LLD driver would
> use the code that compares sc_data_direction with DMA_BIDIRECTIONAL as
> an example.
> 
> BTW, had you already noticed that Christoph Hellwig proposed to modify
> the SCSI core such that sc_data_direction is set to DMA_BIDIRECTIONAL
> for bidi commands ? I'd like to rework this patch series accordingly.
> With that approach no changes are necessary in the ibmvscsi driver.
> 
> Bart.
> 
> 

I only saw the ibmvscsi patch on my way out of the office yesterday
because Brian King forwarded it to me. After looking at the full
patchset I now understand the intent. I did see Christoph's proposal and
agree with the logic of setting DMA_BIDIRECTIONAL for bidi commands.

-Tyrel