From: Douglas Gilbert <dgilbert@interlog.com>
To: Tomas Winkler <tomas.winkler@intel.com>,
"James E.J. Bottomley\"" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [scsi 2/2] scsi_debug: fix REPORT LUNS Well Known LU
Date: Mon, 23 Feb 2015 13:28:48 -0500 [thread overview]
Message-ID: <54EB7160.50600@interlog.com> (raw)
In-Reply-To: <1424690001-2482-2-git-send-email-tomas.winkler@intel.com>
On 15-02-23 06:13 AM, Tomas Winkler wrote:
> The use case to report 'REPORT LUNS WLUN' described
> in scsi_debug documentation didn't work because:
> scsi_scan_host_selected() checks for:
> lun < shost->max_lun
>
> To fix this we set:
> max_lun = SCSI_W_LUN_REPORT_LUNS + 1;
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
> ---
> drivers/scsi/scsi_debug.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index f032aac75997..2c49ddd8d18b 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -700,7 +700,7 @@ static void sdebug_max_tgts_luns(void)
> else
> hpnt->max_id = scsi_debug_num_tgts;
> /* scsi_debug_max_luns; */
> - hpnt->max_lun = SCSI_W_LUN_REPORT_LUNS;
> + hpnt->max_lun = SCSI_W_LUN_REPORT_LUNS + 1;
> }
> spin_unlock(&sdebug_host_list_lock);
> }
> @@ -5344,7 +5344,8 @@ static int sdebug_driver_probe(struct device * dev)
> hpnt->max_id = scsi_debug_num_tgts + 1;
> else
> hpnt->max_id = scsi_debug_num_tgts;
> - hpnt->max_lun = SCSI_W_LUN_REPORT_LUNS; /* = scsi_debug_max_luns; */
> + /* = scsi_debug_max_luns; */
> + hpnt->max_lun = SCSI_W_LUN_REPORT_LUNS + 1;
>
> host_prot = 0;
>
>
next prev parent reply other threads:[~2015-02-23 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 11:13 [scsi 1/2] scsi_debug: schedule_resp fix input variable check Tomas Winkler
2015-02-23 11:13 ` [scsi 2/2] scsi_debug: fix REPORT LUNS Well Known LU Tomas Winkler
2015-02-23 18:28 ` Douglas Gilbert [this message]
2015-05-12 7:56 ` Winkler, Tomas
2015-02-23 14:49 ` [scsi 1/2] scsi_debug: schedule_resp fix input variable check Douglas Gilbert
2015-02-23 15:14 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB7160.50600@interlog.com \
--to=dgilbert@interlog.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox