From: Brian King <brking@linux.vnet.ibm.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
James Bottomley <jbottomley@parallels.com>
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] ibmvfc: Fix a locking imbalance
Date: Thu, 05 Mar 2015 07:35:50 -0600 [thread overview]
Message-ID: <54F85BB6.7030504@linux.vnet.ibm.com> (raw)
In-Reply-To: <54F6D85E.5060906@sandisk.com>
On 03/04/2015 04:03 AM, Bart Van Assche wrote:
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 057d277..b46257a 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct *work)
> tgt_dbg(tgt, "Setting rport roles\n");
> fc_remote_port_rolechg(rport, tgt->ids.roles);
> put_device(&rport->dev);
> + } else {
> + spin_unlock_irqrestore(vhost->host->host_lock, flags);
> }
>
> kref_put(&tgt->kref, ibmvfc_release_tgt);
>
Nice catch. Thanks.
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
prev parent reply other threads:[~2015-03-05 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 10:03 [PATCH] ibmvfc: Fix a locking imbalance Bart Van Assche
2015-03-05 13:35 ` Brian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F85BB6.7030504@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=bart.vanassche@sandisk.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox