From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Subject: Re: [PATCH 01/21] lpfc: Fix the iteration count to match the 30 sec comment Date: Mon, 9 Mar 2015 10:07:40 -0400 Message-ID: <54FDA92C.3040407@emulex.com> References: <1423164184.7917.25.camel@myfc17> <1425746650.2969.3.camel@HansenPartnership.com> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from cmexedge1.emulex.com ([138.239.224.99]:18028 "EHLO CMEXEDGE1.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753514AbbCIOIM (ORCPT ); Mon, 9 Mar 2015 10:08:12 -0400 In-Reply-To: <1425746650.2969.3.camel@HansenPartnership.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: linux-scsi@vger.kernel.org Yes, I'll correct this. Trying to make Christoph happy by using git to format all the patches. -- james On 3/7/2015 11:44 AM, James Bottomley wrote: > On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote: >> --- > Could you put the signoffs (and any changelog) above here, please. You > seem to be using git to generate the patches, so if you just put them in > the git change log the right thing will happen. If you don't do this, > all your patches have to be hand edited to apply them, which is a royal > pain for a maintainer. > >> drivers/scsi/lpfc/lpfc_init.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c >> index 0b2c53a..2b5b910 100644 >> --- a/drivers/scsi/lpfc/lpfc_init.c >> +++ b/drivers/scsi/lpfc/lpfc_init.c >> @@ -7953,7 +7953,7 @@ wait: >> * up to 30 seconds. If the port doesn't respond, treat >> * it as an error. >> */ >> - for (rdy_chk = 0; rdy_chk < 3000; rdy_chk++) { >> + for (rdy_chk = 0; rdy_chk < 1500; rdy_chk++) { >> if (lpfc_readl(phba->sli4_hba.u.if_type2. >> STATUSregaddr, ®_data.word0)) { >> rc = -ENODEV; >> -- >> 1.7.11.7 >> >> Signed-off-by: James Smart >> Signed-off-by: Dick Kennedy > I'm not quite understanding this signoff chain. It reads like Dick > Kennedy is the author, in which case the patch needs a From: at > the top to make this clear. If it's jointly authored, then > traditionally he'd still be the first signoff because the series of > signoffs represents the transmission chain and you send the patch, so > you should be last signoff. > > James > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >