From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800BBC38A2A for ; Thu, 7 May 2020 09:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 603D020CC7 for ; Thu, 7 May 2020 09:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbgEGJu7 (ORCPT ); Thu, 7 May 2020 05:50:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:59084 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbgEGJu7 (ORCPT ); Thu, 7 May 2020 05:50:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0E702AFF2; Thu, 7 May 2020 09:51:01 +0000 (UTC) Subject: Re: [PATCH 8/9] lpfc: Fix MDS Diagnostic Enablement definition To: James Smart , linux-scsi@vger.kernel.org Cc: Dick Kennedy References: <20200501214310.91713-1-jsmart2021@gmail.com> <20200501214310.91713-9-jsmart2021@gmail.com> From: Hannes Reinecke Message-ID: <54f0d366-6669-de34-a26d-5f8a9289673c@suse.de> Date: Thu, 7 May 2020 11:50:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200501214310.91713-9-jsmart2021@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 5/1/20 11:43 PM, James Smart wrote: > The MDS diagnostic enablement bit for the adapter interface is incorrect > in the driver header. > > Correct the bit position for the SET_FEATURE MDS bit. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_hw4.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h > index 10c5d1c3122e..6dfff0376547 100644 > --- a/drivers/scsi/lpfc/lpfc_hw4.h > +++ b/drivers/scsi/lpfc/lpfc_hw4.h > @@ -3541,7 +3541,7 @@ struct lpfc_mbx_set_feature { > #define lpfc_mbx_set_feature_UER_SHIFT 0 > #define lpfc_mbx_set_feature_UER_MASK 0x00000001 > #define lpfc_mbx_set_feature_UER_WORD word6 > -#define lpfc_mbx_set_feature_mds_SHIFT 0 > +#define lpfc_mbx_set_feature_mds_SHIFT 2 > #define lpfc_mbx_set_feature_mds_MASK 0x00000001 > #define lpfc_mbx_set_feature_mds_WORD word6 > #define lpfc_mbx_set_feature_mds_deep_loopbk_SHIFT 1 > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer