linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Himanshu Madhani <himanshu.madhani@qlogic.com>, jbottomley@parallels.com
Cc: hch@lst.de, giridhar.malavali@qlogic.com,
	andrew.vasquez@qlogic.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 07/14] qla2xxx: Add udev notification to save fw dump for ISP27XX
Date: Fri, 10 Apr 2015 08:35:18 +0200	[thread overview]
Message-ID: <55276F26.4040204@suse.de> (raw)
In-Reply-To: <1428606008-14976-8-git-send-email-himanshu.madhani@qlogic.com>

On 04/09/2015 09:00 PM, Himanshu Madhani wrote:
> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
> ---
>  drivers/scsi/qla2xxx/qla_tmpl.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
> index 1437fce..7f67fb2 100644
> --- a/drivers/scsi/qla2xxx/qla_tmpl.c
> +++ b/drivers/scsi/qla2xxx/qla_tmpl.c
> @@ -787,11 +787,12 @@ qla27xx_walk_template(struct scsi_qla_host *vha,
>  	ql_dbg(ql_dbg_misc, vha, 0xd01b,
>  	    "%s: len=%lx\n", __func__, *len);
>  
> -	if (buf)
> +	if (buf) {
>  		ql_log(ql_log_warn, vha, 0xd015,
>  		    "Firmware dump saved to temp buffer (%ld/%p)\n",
>  		    vha->host_no, vha->hw->fw_dump);
> -
> +		qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);
> +	}
>  }
>  
>  static void
> 
Hmm? Isn't that the same as in the previous patch?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-04-10  6:35 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 18:59 [PATCH 00/14] qla2xxx: Patches for scsi "misc" branch Himanshu Madhani
2015-04-09 18:59 ` [PATCH 01/14] qla2xxx: Fix warnings reported by static checker Himanshu Madhani
2015-04-10  6:30   ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 02/14] qla2xxx: Fix crash due to wrong casting of reg for ISP27XX Himanshu Madhani
2015-04-10  5:59   ` Bart Van Assche
2015-04-10  6:31   ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 03/14] qla2xxx: Increase the wait time for firmware to be ready for P3P Himanshu Madhani
2015-04-10  6:31   ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 04/14] qla2xxx: Fix beacon blink for ISP27XX Himanshu Madhani
2015-04-10  6:32   ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 05/14] qla2xxx: Add support to load firmware from file for ISP 26XX/27XX Himanshu Madhani
2015-04-10  6:33   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 06/14] qla2xxx: Add message for sucessful FW dump collected for ISP27XX Himanshu Madhani
2015-04-10  6:33   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 07/14] qla2xxx: Add udev notification to save fw dump " Himanshu Madhani
2015-04-10  6:35   ` Hannes Reinecke [this message]
2015-04-09 19:00 ` [PATCH 08/14] qla2xxx: Add serdes read/write support " Himanshu Madhani
2015-04-10  6:35   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 09/14] qla2xxx: Add debugging info for MBX timeout Himanshu Madhani
2015-04-10  6:36   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 10/14] qla2xxx: Disable Interrupt handshake for ISP27XX Himanshu Madhani
2015-04-10  6:37   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 11/14] qla2xxx: Prevent multiple firmware dump collection " Himanshu Madhani
2015-04-10  6:37   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 12/14] qla2xxx: Fix virtual port configuration, when switch port is disabled/enabled Himanshu Madhani
2015-04-10  6:38   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 13/14] qla2xxx: Restore physical port WWPN only, when port down detected for FA-WWPN port Himanshu Madhani
2015-04-10  6:39   ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 14/14] qla2xxx: Update driver version to 8.07.00.18-k Himanshu Madhani
2015-04-10  6:39   ` Hannes Reinecke
2015-04-10  5:53 ` [PATCH 00/14] qla2xxx: Patches for scsi "misc" branch Bart Van Assche
2015-04-10 15:46   ` James Bottomley
2015-04-10 18:46   ` Himanshu Madhani
2015-06-02 19:52   ` Himanshu Madhani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55276F26.4040204@suse.de \
    --to=hare@suse.de \
    --cc=andrew.vasquez@qlogic.com \
    --cc=giridhar.malavali@qlogic.com \
    --cc=hch@lst.de \
    --cc=himanshu.madhani@qlogic.com \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).