From: Joe Lawrence <joe.lawrence@stratus.com>
To: linux-scsi@vger.kernel.org
Cc: Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups
Date: Sun, 12 Apr 2015 20:11:04 -0400 [thread overview]
Message-ID: <552B0998.1050808@stratus.com> (raw)
In-Reply-To: <1419948455-31624-1-git-send-email-joe.lawrence@stratus.com>
On 12/30/2014 09:07 AM, Joe Lawrence wrote:
> A colleague noticed that the mpt2 and mpt3sas drivers do not correctly
> check the PCI master abort pattern in _base_wait_for_doorbell_ack. This
> pattern should be checked *prior* to any valid bit patterns, which would
> always return true since a PCI read on master abort sets all bits high.
>
> The second patch adds similar checking to _base_wait_for_doorbell_int and
> _base_wait_for_doorbell_not_used to avoid potentially long loops around
> PCI reads.
>
> Joe Lawrence (2):
> mpt2sas,mpt3sas: correct master-abort checking in doorbell ack
> mpt2sas,mpt3sas: additional master abort checks
>
> drivers/scsi/mpt2sas/mpt2sas_base.c | 17 ++++++++++++-----
> drivers/scsi/mpt3sas/mpt3sas_base.c | 17 ++++++++++++-----
> 2 files changed, 24 insertions(+), 10 deletions(-)
>
Avago ping?
This one was pretty straightforward: check 0xFFFFFFFF *before* any
individual bit(s), i.e. before reading the doorbell register.
-- Joe
next prev parent reply other threads:[~2015-04-13 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 14:07 [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups Joe Lawrence
2014-12-30 14:07 ` [PATCH 1/2] mpt2sas,mpt3sas: correct master-abort checking in doorbell ack Joe Lawrence
2014-12-30 14:07 ` [PATCH 2/2] mpt2sas,mpt3sas: additional master abort checks Joe Lawrence
2015-04-13 0:11 ` Joe Lawrence [this message]
2015-04-13 0:54 ` [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups James Bottomley
2015-04-13 14:06 ` Joe Lawrence
2015-04-13 14:38 ` James Bottomley
2015-04-13 15:44 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552B0998.1050808@stratus.com \
--to=joe.lawrence@stratus.com \
--cc=JBottomley@parallels.com \
--cc=abhijit.mahajan@avagotech.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nagalakshmi.nandigama@avagotech.com \
--cc=praveen.krishnamoorthy@avagotech.com \
--cc=sreekanth.reddy@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).