From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: stable@vger.kernel.org.#.v3.17+
Subject: Re: [PATCH] sd: Unregister integrity profile
Date: Wed, 15 Apr 2015 12:22:17 +0300 [thread overview]
Message-ID: <552E2DC9.9020200@dev.mellanox.co.il> (raw)
In-Reply-To: <1429044983-3584-1-git-send-email-martin.petersen@oracle.com>
On 4/14/2015 11:56 PM, Martin K. Petersen wrote:
> The new integrity code did not correctly unregister the profile for SD
> disks. Call blk_integrity_unregister() when we release a disk.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reported-by: Sagi Grimberg <sagig@dev.mellanox.co.il>
> CC: stable@vger.kernel.org # v3.17+
Has it been there this long? I wander how we didn't step on
this sooner...
> ---
> drivers/scsi/sd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 6b78476d04bb..3290a3ed5b31 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -3100,6 +3100,7 @@ static void scsi_disk_release(struct device *dev)
> ida_remove(&sd_index_ida, sdkp->index);
> spin_unlock(&sd_index_lock);
>
> + blk_integrity_unregister(disk);
> disk->private_data = NULL;
> put_disk(disk);
> put_device(&sdkp->device->sdev_gendev);
>
Always nice to post a trace, go home, and find the fix in
the next morning...
Thanks Martin!
Tested-by: Sagi Grimberg <sagig@mellanox.com>
prev parent reply other threads:[~2015-04-15 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 16:52 Has anyone seen this? Sagi Grimberg
2015-04-14 17:57 ` Douglas Gilbert
2015-04-14 18:14 ` James Bottomley
2015-04-14 18:18 ` Martin K. Petersen
2015-04-14 20:56 ` [PATCH] sd: Unregister integrity profile Martin K. Petersen
2015-04-15 9:22 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E2DC9.9020200@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org.#.v3.17+ \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox