* [PATCH 01/10] ufs: introduce setup_xfer_req callback
@ 2016-10-08 3:21 Kiwoong Kim
2016-10-08 16:41 ` Subhash Jadavani
[not found] ` <CGME20161008164138epcas2p32368d7db5b175550e9ef3e9c32818a42@epcas2p3.samsung.com>
0 siblings, 2 replies; 3+ messages in thread
From: Kiwoong Kim @ 2016-10-08 3:21 UTC (permalink / raw)
To: vinholikatti, 'Martin K. Petersen'
Cc: linux-scsi, 'James Bottomley',
'추헌광'
Some UFS host controller may need to configure some things
before any transfer request is issued.
Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
drivers/scsi/ufs/ufshcd.c | 2 ++
drivers/scsi/ufs/ufshcd.h | 10 ++++++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 05c7456..bb537db 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1474,6 +1474,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
/* issue command to the controller */
spin_lock_irqsave(hba->host->host_lock, flags);
+ ufshcd_vops_setup_xfer_req(hba, tag, (lrbp->cmd ? true : false));
ufshcd_send_command(hba, tag);
out_unlock:
spin_unlock_irqrestore(hba->host->host_lock, flags);
@@ -1683,6 +1684,7 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
/* Make sure descriptors are ready before ringing the doorbell */
wmb();
spin_lock_irqsave(hba->host->host_lock, flags);
+ ufshcd_vops_setup_xfer_req(hba, tag, (lrbp->cmd ? true : false));
ufshcd_send_command(hba, tag);
spin_unlock_irqrestore(hba->host->host_lock, flags);
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 430bef1..f37e5a4 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -261,6 +261,8 @@ struct ufs_pwr_mode_info {
* @pwr_change_notify: called before and after a power mode change
* is carried out to allow vendor spesific capabilities
* to be set.
+ * @setup_xfer_req: called before any transfer request is issued
+ * to set some things
* @suspend: called during host controller PM callback
* @resume: called during host controller PM callback
* @dbg_register_dump: used to dump controller debug information
@@ -283,6 +285,7 @@ struct ufs_hba_variant_ops {
enum ufs_notify_change_status status,
struct ufs_pa_layer_attr *,
struct ufs_pa_layer_attr *);
+ void (*setup_xfer_req)(struct ufs_hba *, int, bool);
int (*suspend)(struct ufs_hba *, enum ufs_pm_op);
int (*resume)(struct ufs_hba *, enum ufs_pm_op);
void (*dbg_register_dump)(struct ufs_hba *hba);
@@ -799,6 +802,13 @@ static inline int ufshcd_vops_pwr_change_notify(struct ufs_hba *hba,
return -ENOTSUPP;
}
+static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba *hba, int tag,
+ bool is_cmd_not_null)
+{
+ if (hba->vops && hba->vops->setup_xfer_req)
+ return hba->vops->setup_xfer_req(hba, tag, is_cmd_not_null);
+}
+
static inline int ufshcd_vops_suspend(struct ufs_hba *hba, enum ufs_pm_op op)
{
if (hba->vops && hba->vops->suspend)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 01/10] ufs: introduce setup_xfer_req callback
2016-10-08 3:21 [PATCH 01/10] ufs: introduce setup_xfer_req callback Kiwoong Kim
@ 2016-10-08 16:41 ` Subhash Jadavani
[not found] ` <CGME20161008164138epcas2p32368d7db5b175550e9ef3e9c32818a42@epcas2p3.samsung.com>
1 sibling, 0 replies; 3+ messages in thread
From: Subhash Jadavani @ 2016-10-08 16:41 UTC (permalink / raw)
To: Kiwoong Kim
Cc: vinholikatti, 'Martin K. Petersen', linux-scsi,
'James Bottomley', '추헌광',
linux-scsi-owner
On 2016-10-07 20:21, Kiwoong Kim wrote:
> Some UFS host controller may need to configure some things
> before any transfer request is issued.
>
> Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 ++
> drivers/scsi/ufs/ufshcd.h | 10 ++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 05c7456..bb537db 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1474,6 +1474,7 @@ static int ufshcd_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *cmd)
>
> /* issue command to the controller */
> spin_lock_irqsave(hba->host->host_lock, flags);
> + ufshcd_vops_setup_xfer_req(hba, tag, (lrbp->cmd ? true : false));
> ufshcd_send_command(hba, tag);
> out_unlock:
> spin_unlock_irqrestore(hba->host->host_lock, flags);
> @@ -1683,6 +1684,7 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba
> *hba,
> /* Make sure descriptors are ready before ringing the doorbell */
> wmb();
> spin_lock_irqsave(hba->host->host_lock, flags);
> + ufshcd_vops_setup_xfer_req(hba, tag, (lrbp->cmd ? true : false));
> ufshcd_send_command(hba, tag);
> spin_unlock_irqrestore(hba->host->host_lock, flags);
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 430bef1..f37e5a4 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -261,6 +261,8 @@ struct ufs_pwr_mode_info {
> * @pwr_change_notify: called before and after a power mode change
> * is carried out to allow vendor spesific capabilities
> * to be set.
> + * @setup_xfer_req: called before any transfer request is issued
> + * to set some things
> * @suspend: called during host controller PM callback
> * @resume: called during host controller PM callback
> * @dbg_register_dump: used to dump controller debug information
> @@ -283,6 +285,7 @@ struct ufs_hba_variant_ops {
> enum ufs_notify_change_status status,
> struct ufs_pa_layer_attr *,
> struct ufs_pa_layer_attr *);
> + void (*setup_xfer_req)(struct ufs_hba *, int, bool);
> int (*suspend)(struct ufs_hba *, enum ufs_pm_op);
> int (*resume)(struct ufs_hba *, enum ufs_pm_op);
> void (*dbg_register_dump)(struct ufs_hba *hba);
> @@ -799,6 +802,13 @@ static inline int
> ufshcd_vops_pwr_change_notify(struct ufs_hba *hba,
> return -ENOTSUPP;
> }
>
> +static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba *hba, int
> tag,
> + bool is_cmd_not_null)
This might sound better: s/is_cmd_not_null/is_scsi_cmd ?
> +{
> + if (hba->vops && hba->vops->setup_xfer_req)
> + return hba->vops->setup_xfer_req(hba, tag, is_cmd_not_null);
> +}
> +
> static inline int ufshcd_vops_suspend(struct ufs_hba *hba, enum
> ufs_pm_op op)
> {
> if (hba->vops && hba->vops->suspend)
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <CGME20161008164138epcas2p32368d7db5b175550e9ef3e9c32818a42@epcas2p3.samsung.com>]
* Re: [PATCH 01/10] ufs: introduce setup_xfer_req callback.
[not found] ` <CGME20161008164138epcas2p32368d7db5b175550e9ef3e9c32818a42@epcas2p3.samsung.com>
@ 2016-10-10 7:06 ` 김기웅
0 siblings, 0 replies; 3+ messages in thread
From: 김기웅 @ 2016-10-10 7:06 UTC (permalink / raw)
To: Subhash Jadavani; +Cc: linux-scsi@vger.kernel.org, 추헌광
[-- Attachment #1: Type: text/plain, Size: 3612 bytes --]
Hi, Subhash
> On 2016-10-07 20:21, Kiwoong Kim wrote:
> > Some UFS host controller may need to configure some things before any
> > transfer request is issued.
> >
> > Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
> > ---
> > drivers/scsi/ufs/ufshcd.c | 2 ++
> > drivers/scsi/ufs/ufshcd.h | 10 ++++++++++
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index 05c7456..bb537db 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -1474,6 +1474,7 @@ static int ufshcd_queuecommand(struct Scsi_Host
> > *host, struct scsi_cmnd *cmd)
> >
> > /* issue command to the controller */
> > spin_lock_irqsave(hba->host->host_lock, flags);
> > + ufshcd_vops_setup_xfer_req(hba, tag, (lrbp->cmd ? true : false));
> > ufshcd_send_command(hba, tag);
> > out_unlock:
> > spin_unlock_irqrestore(hba->host->host_lock, flags); @@ -1683,6
> > +1684,7 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
> > /* Make sure descriptors are ready before ringing the doorbell */
> > wmb();
> > spin_lock_irqsave(hba->host->host_lock, flags);
> > + ufshcd_vops_setup_xfer_req(hba, tag, (lrbp->cmd ? true : false));
> > ufshcd_send_command(hba, tag);
> > spin_unlock_irqrestore(hba->host->host_lock, flags);
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > index 430bef1..f37e5a4 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -261,6 +261,8 @@ struct ufs_pwr_mode_info {
> > * @pwr_change_notify: called before and after a power mode change
> > * is carried out to allow vendor spesific capabilities
> > * to be set.
> > + * @setup_xfer_req: called before any transfer request is issued
> > + * to set some things
> > * @suspend: called during host controller PM callback
> > * @resume: called during host controller PM callback
> > * @dbg_register_dump: used to dump controller debug information @@
> > -283,6 +285,7 @@ struct ufs_hba_variant_ops {
> > enum ufs_notify_change_status status,
> > struct ufs_pa_layer_attr *,
> > struct ufs_pa_layer_attr *);
> > + void (*setup_xfer_req)(struct ufs_hba *, int, bool);
> > int (*suspend)(struct ufs_hba *, enum ufs_pm_op);
> > int (*resume)(struct ufs_hba *, enum ufs_pm_op);
> > void (*dbg_register_dump)(struct ufs_hba *hba);
> > @@ -799,6 +802,13 @@ static inline int
> > ufshcd_vops_pwr_change_notify(struct ufs_hba *hba,
> > return -ENOTSUPP;
> > }
> >
> > +static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba *hba,
> > +int
> > tag,
> > + bool is_cmd_not_null)
>
> This might sound better: s/is_cmd_not_null/is_scsi_cmd ?
Okay.
And I think mail threading may be not avaiable in my environment
modifying a title of original message.
I would fix this issue or submit each patch at a time.
Thank you.
Regards.
>
> > +{
> > + if (hba->vops && hba->vops->setup_xfer_req)
> > + return hba->vops->setup_xfer_req(hba, tag,
> is_cmd_not_null); }
> > +
> > static inline int ufshcd_vops_suspend(struct ufs_hba *hba, enum
> > ufs_pm_op op) {
> > if (hba->vops && hba->vops->suspend)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
> Linux Foundation Collaborative Project
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-10 7:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-08 3:21 [PATCH 01/10] ufs: introduce setup_xfer_req callback Kiwoong Kim
2016-10-08 16:41 ` Subhash Jadavani
[not found] ` <CGME20161008164138epcas2p32368d7db5b175550e9ef3e9c32818a42@epcas2p3.samsung.com>
2016-10-10 7:06 ` 김기웅
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).