From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH RESEND 14/18] megaraid_sas : move endianess conversion into caller of megasas_get_seq_num Date: Tue, 21 Apr 2015 12:30:53 +0200 Message-ID: <553626DD.3070906@suse.de> References: <201504201236.t3KCaqIg016688@palmhbs0.lsi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:33203 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbbDUKaz (ORCPT ); Tue, 21 Apr 2015 06:30:55 -0400 In-Reply-To: <201504201236.t3KCaqIg016688@palmhbs0.lsi.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Sumit.Saxena@avagotech.com, linux-scsi@vger.kernel.org Cc: thenzl@redhat.com, martin.petersen@oracle.com, hch@infradead.org, jbottomley@parallels.com, kashyap.desai@avagotech.com On 04/20/2015 02:34 PM, Sumit.Saxena@avagotech.com wrote: > Converting structure fields in place is always a bad idea, and in thi= s case > by moving it into the only caller we also only have to do a single by= te > swap as most fields of this structure are never used. >=20 > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html