From: Hannes Reinecke <hare@suse.de>
To: Sumit.Saxena@avagotech.com, linux-scsi@vger.kernel.org
Cc: thenzl@redhat.com, martin.petersen@oracle.com, hch@infradead.org,
jbottomley@parallels.com, kashyap.desai@avagotech.com
Subject: Re: [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static
Date: Tue, 21 Apr 2015 12:33:25 +0200 [thread overview]
Message-ID: <55362775.9090603@suse.de> (raw)
In-Reply-To: <201504201238.t3KCc8GM016945@palmhbs0.lsi.com>
On 04/20/2015 02:35 PM, Sumit.Saxena@avagotech.com wrote:
> drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 2424ab2..0381833 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -1695,7 +1695,7 @@ static int megasas_slave_alloc(struct scsi_device *sdev)
> * @instance: Adapter soft state
> *
> */
> -void megasas_complete_outstanding_ioctls(struct megasas_instance *instance)
> +static void megasas_complete_outstanding_ioctls(struct megasas_instance *instance)
> {
> int i;
> struct megasas_cmd *cmd_mfi;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-21 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 12:35 [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static Sumit.Saxena
2015-04-21 10:33 ` Hannes Reinecke [this message]
2015-04-21 12:34 ` Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55362775.9090603@suse.de \
--to=hare@suse.de \
--cc=Sumit.Saxena@avagotech.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox