* [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static
@ 2015-04-20 12:35 Sumit.Saxena
2015-04-21 10:33 ` Hannes Reinecke
2015-04-21 12:34 ` Tomas Henzl
0 siblings, 2 replies; 3+ messages in thread
From: Sumit.Saxena @ 2015-04-20 12:35 UTC (permalink / raw)
To: linux-scsi
Cc: thenzl, martin.petersen, hch, jbottomley, kashyap.desai,
sumit.saxena
drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 2424ab2..0381833 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -1695,7 +1695,7 @@ static int megasas_slave_alloc(struct scsi_device *sdev)
* @instance: Adapter soft state
*
*/
-void megasas_complete_outstanding_ioctls(struct megasas_instance *instance)
+static void megasas_complete_outstanding_ioctls(struct megasas_instance *instance)
{
int i;
struct megasas_cmd *cmd_mfi;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static
2015-04-20 12:35 [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static Sumit.Saxena
@ 2015-04-21 10:33 ` Hannes Reinecke
2015-04-21 12:34 ` Tomas Henzl
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2015-04-21 10:33 UTC (permalink / raw)
To: Sumit.Saxena, linux-scsi
Cc: thenzl, martin.petersen, hch, jbottomley, kashyap.desai
On 04/20/2015 02:35 PM, Sumit.Saxena@avagotech.com wrote:
> drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 2424ab2..0381833 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -1695,7 +1695,7 @@ static int megasas_slave_alloc(struct scsi_device *sdev)
> * @instance: Adapter soft state
> *
> */
> -void megasas_complete_outstanding_ioctls(struct megasas_instance *instance)
> +static void megasas_complete_outstanding_ioctls(struct megasas_instance *instance)
> {
> int i;
> struct megasas_cmd *cmd_mfi;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static
2015-04-20 12:35 [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static Sumit.Saxena
2015-04-21 10:33 ` Hannes Reinecke
@ 2015-04-21 12:34 ` Tomas Henzl
1 sibling, 0 replies; 3+ messages in thread
From: Tomas Henzl @ 2015-04-21 12:34 UTC (permalink / raw)
To: Sumit.Saxena, linux-scsi; +Cc: martin.petersen, hch, jbottomley, kashyap.desai
On 04/20/2015 02:35 PM, Sumit.Saxena@avagotech.com wrote:
> drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-21 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-20 12:35 [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static Sumit.Saxena
2015-04-21 10:33 ` Hannes Reinecke
2015-04-21 12:34 ` Tomas Henzl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox