From: Gionatan Danti <g.danti@assyoma.it>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
Tejun Heo <htejun@gmail.com>
Subject: Re: No I/O errors reported after SATA link hard reset
Date: Thu, 17 Aug 2017 17:01:36 +0200 [thread overview]
Message-ID: <5546b954a6f291189a7d949ba8ced69a@assyoma.it> (raw)
In-Reply-To: <20170817144657.GF3238792@devbig577.frc2.facebook.com>
Il 17-08-2017 16:46 Tejun Heo ha scritto:
> Upper layer can request to avoid retrying on errors but it won't help
> too much. It doesn't have much to do with specific commands. A power
> event can take place without any command in flight and lose the
> buffered data. Unless upper layer is tracking all that's being
> written, there isn't much it can do outside doing full scan. This is
> a condition which should be handled from the driver side.
True, I was not thinking about buffered (delayed) writes. However, for
synchronized writes it should be possible: after all, for sync() writes
the application is waiting for its completion. This means that if a
powerloss/link renegotiation is detected between *the two FLUSH_CACHE
commands*, and I/O error can be reported to the calling application.
What about disk supporting FUAs? Are they unaffected by this problem? If
my understand it properly, torn writes remain a potential, but
inevitable, problem when facing powerloss conditions.
By the way, when speaking about a "full scan" your are referring to full
bus scanning/enumeration? Will it change devices name when
re-discovering them?
> Yeah, looking into getting it implemented on the kernel side.
Great! Are your thinking about a polling approach or an event-driven
one?
Regards.
--
Danti Gionatan
Supporto Tecnico
Assyoma S.r.l. - www.assyoma.it
email: g.danti@assyoma.it - info@assyoma.it
GPG public key ID: FF5F32A8
next prev parent reply other threads:[~2017-08-17 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 22:27 No I/O errors reported after SATA link hard reset Gionatan Danti
2017-08-17 9:24 ` Bernd Schubert
2017-08-17 12:48 ` Tejun Heo
2017-08-17 13:18 ` Bernd Schubert
2017-08-17 13:25 ` Tejun Heo
2017-08-17 13:43 ` Bernd Schubert
2017-08-17 14:23 ` Gionatan Danti
2017-08-17 14:15 ` Gionatan Danti
2017-08-17 14:46 ` Tejun Heo
2017-08-17 15:01 ` Gionatan Danti [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-26 20:58 sonofagun
2017-08-27 18:42 ` Gionatan Danti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5546b954a6f291189a7d949ba8ced69a@assyoma.it \
--to=g.danti@assyoma.it \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox