From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Cc: Mike Snitzer <snitzer@redhat.com>,
Mike Christie <michaelc@cs.wisc.edu>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 5/9] scsi_dh: integrate into the core SCSI code
Date: Mon, 04 May 2015 09:50:38 +0200 [thread overview]
Message-ID: <554724CE.1090002@suse.de> (raw)
In-Reply-To: <1430415151-30948-6-git-send-email-hch@lst.de>
On 04/30/2015 07:32 PM, Christoph Hellwig wrote:
> Stop building scsi_dh as a separate module and integrate it fully into the
> core SCSI code with explicit callouts at bus scan time. For now the
> callouts are placed at the same point as the old bus notifiers were called,
> but in the future we will be able to look at ALUA INQUIRY data earlier on.
>
> Note that this also means that the device handler modules need to be loaded
> by the time we scan the bus. The next patches will add support for
> autoloading device handlers at bus scan time to make sure they are always
> loaded if they are enabled in the kernel config.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/scsi/Makefile | 1 +
> drivers/scsi/device_handler/Kconfig | 2 +-
> drivers/scsi/device_handler/Makefile | 1 -
> drivers/scsi/device_handler/scsi_dh.c | 185 +++-------------------------------
> drivers/scsi/scsi_priv.h | 9 ++
> drivers/scsi/scsi_sysfs.c | 10 ++
> include/scsi/scsi_dh.h | 2 +-
> 7 files changed, 35 insertions(+), 175 deletions(-)
>
> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
> index dee160a..df2f656 100644
> --- a/drivers/scsi/Makefile
> +++ b/drivers/scsi/Makefile
> @@ -169,6 +169,7 @@ scsi_mod-$(CONFIG_SYSCTL) += scsi_sysctl.o
> scsi_mod-$(CONFIG_SCSI_PROC_FS) += scsi_proc.o
> scsi_mod-y += scsi_trace.o scsi_logging.o
> scsi_mod-$(CONFIG_PM) += scsi_pm.o
> +scsi_mod-$(CONFIG_SCSI_DH) += device_handler/scsi_dh.o
>
> hv_storvsc-y := storvsc_drv.o
>
> diff --git a/drivers/scsi/device_handler/Kconfig b/drivers/scsi/device_handler/Kconfig
> index 69abd0a..e5647d5 100644
> --- a/drivers/scsi/device_handler/Kconfig
> +++ b/drivers/scsi/device_handler/Kconfig
> @@ -3,7 +3,7 @@
> #
>
> menuconfig SCSI_DH
> - tristate "SCSI Device Handlers"
> + bool "SCSI Device Handlers"
> depends on SCSI
> default n
> help
> diff --git a/drivers/scsi/device_handler/Makefile b/drivers/scsi/device_handler/Makefile
> index e1d2ea0..09866c5 100644
> --- a/drivers/scsi/device_handler/Makefile
> +++ b/drivers/scsi/device_handler/Makefile
> @@ -1,7 +1,6 @@
> #
> # SCSI Device Handler
> #
> -obj-$(CONFIG_SCSI_DH) += scsi_dh.o
> obj-$(CONFIG_SCSI_DH_RDAC) += scsi_dh_rdac.o
> obj-$(CONFIG_SCSI_DH_HP_SW) += scsi_dh_hp_sw.o
> obj-$(CONFIG_SCSI_DH_EMC) += scsi_dh_emc.o
> diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
> index e6ed565..cb336a4 100644
> --- a/drivers/scsi/device_handler/scsi_dh.c
> +++ b/drivers/scsi/device_handler/scsi_dh.c
> @@ -24,7 +24,7 @@
> #include <linux/slab.h>
> #include <linux/module.h>
> #include <scsi/scsi_dh.h>
> -#include "../scsi_priv.h"
> +#include "scsi_priv.h"
>
This doesn't compile; 'scsi_dh' is still at it's old location.
Please remove this hunk.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-04 7:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 17:32 integrate scsi_dh better into the scsi core Christoph Hellwig
2015-04-30 17:32 ` [PATCH 1/9] dm-mpath: check kstrdup return value in parse_hw_handler Christoph Hellwig
2015-04-30 18:35 ` Hannes Reinecke
2015-05-01 13:57 ` Mike Snitzer
2015-05-01 15:07 ` Martin K. Petersen
2015-05-01 15:29 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 2/9] dm-mpath, scsi_dh: don't let dm detach device handlers Christoph Hellwig
2015-04-30 18:21 ` Mike Snitzer
2015-05-01 9:20 ` Christoph Hellwig
2015-05-01 7:10 ` Hannes Reinecke
2015-05-01 13:58 ` Mike Snitzer
2015-05-01 15:30 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 3/9] dm-mpath: don't call scsi_dh_attach when we want to retain the attached handler Christoph Hellwig
2015-04-30 18:25 ` Mike Snitzer
2015-05-01 7:10 ` Hannes Reinecke
2015-05-01 15:34 ` Martin K. Petersen
2015-05-01 16:46 ` Christoph Hellwig
2015-04-30 17:32 ` [PATCH 4/9] dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath Christoph Hellwig
2015-04-30 18:28 ` Mike Snitzer
2015-05-01 7:11 ` Hannes Reinecke
2015-05-01 13:59 ` Mike Snitzer
2015-05-01 15:35 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 5/9] scsi_dh: integrate into the core SCSI code Christoph Hellwig
2015-05-01 7:13 ` Hannes Reinecke
2015-05-01 15:36 ` Martin K. Petersen
2015-05-04 7:50 ` Hannes Reinecke [this message]
2015-05-05 15:25 ` Christoph Hellwig
2015-04-30 17:32 ` [PATCH 6/9] scsi_dh: move device matching to the core code Christoph Hellwig
2015-04-30 18:32 ` Mike Snitzer
2015-05-01 7:15 ` Hannes Reinecke
2015-05-01 15:39 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 7/9] scsi_dh: kill struct scsi_dh_data Christoph Hellwig
2015-05-01 7:17 ` Hannes Reinecke
2015-05-01 15:41 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 8/9] scsi_dh: add a common helper to get a scsi_device from a request_queue Christoph Hellwig
2015-05-01 7:18 ` Hannes Reinecke
2015-05-01 15:45 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 9/9] scsi_dh: don't allow to detach device handlers at runtime Christoph Hellwig
2015-05-01 7:19 ` Hannes Reinecke
2015-05-01 15:46 ` Martin K. Petersen
2015-04-30 18:31 ` integrate scsi_dh better into the scsi core Mike Snitzer
2015-05-01 15:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554724CE.1090002@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).