From: Bart Van Assche <bvanassche@acm.org>
To: Liang He <windhl@126.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] ufs: host: ufschd-pltfrm: Hold reference returned by of_parse_phandle()
Date: Tue, 19 Jul 2022 11:12:36 -0700 [thread overview]
Message-ID: <554f38b5-8506-2ab3-dbff-bcc18b00000f@acm.org> (raw)
In-Reply-To: <23e4cd6a.1fef.18214599628.Coremail.windhl@126.com>
On 7/18/22 19:46, Liang He wrote:
> Can you help me as I have a trouble about the indentation.
>
> When I align descendants to a function open parenthesis in VIM editor,
> but when I generate the patch, I find the second line always missing one space in
> patch format. So is there any problem if I send this patch?
>
> I make sure that the alignment in VIM is OK.
Hi Liang,
Please don't worry about this. When a code change is converted into a
patch, a single character is inserted at the start of each line (plus,
minus or space). That makes code that is indented with tabs look weird.
This is normal.
Bart.
next prev parent reply other threads:[~2022-07-19 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 0:17 [PATCH v2] ufs: host: ufschd-pltfrm: Hold reference returned by of_parse_phandle() Liang He
2022-07-16 13:50 ` Bart Van Assche
2022-07-17 3:03 ` Liang He
2022-07-17 14:58 ` Bart Van Assche
2022-07-18 8:30 ` Liang He
2022-07-19 2:46 ` Liang He
2022-07-19 18:12 ` Bart Van Assche [this message]
2022-07-20 0:48 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554f38b5-8506-2ab3-dbff-bcc18b00000f@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox