Re: [PATCH 3/9] [SCSI] aacraid: Enable MSI interrupt for series-6 controller

[Tomas Henzl <thenzl@redhat.com>]

On 05/23/2015 01:46 AM, Rajinikanth Pandurangan wrote:
> Hello Tomas,
> 
> As the function aac_src_init() itself specific to Series-6 controller, change applicable only to series-6.
The change removes a kernel option, which assumedly
is used to control which kind of interrupt handling
the driver may use. With aac_msi = 1 the driver
might have used MSI -> the text "Enable MSI interrupt mode"
is misleading.
Let's say the text isn't precise - but i can accept it,
so you don't have to repost.

Tomas


> Thanks,
> -Raj P.
> 
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com] 
> Sent: Friday, May 22, 2015 6:40 AM
> To: Rajinikanth Pandurangan; jbottomley@parallels.com; linux-scsi@vger.kernel.org
> Cc: aacraid@pmc-sierra.com; Harry Yang; Rich Bono; Achim Leubner; Murthy Bhat
> Subject: Re: [PATCH 3/9] [SCSI] aacraid: Enable MSI interrupt for series-6 controller
> 
> On 05/14/2015 02:12 AM, rajinikanth.pandurangan@pmcs.com wrote:
>> From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
>>
>> Description:
>> 	Enable MSI interrupt mode for series-6 controller.
> aac_msi is a driver option, how is it related to series-6 controller?
> Tomas
>>
>> Signed-off-by: Rajinikanth Pandurangan 
>> <rajinikanth.pandurangan@pmcs.com>
>> ---
>>  drivers/scsi/aacraid/src.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c 
>> index b0204d0..ae494c5 100644
>> --- a/drivers/scsi/aacraid/src.c
>> +++ b/drivers/scsi/aacraid/src.c
>> @@ -742,7 +742,7 @@ int aac_src_init(struct aac_dev *dev)
>>  	if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE1)
>>  		goto error_iounmap;
>>  
>> -	dev->msi = aac_msi && !pci_enable_msi(dev->pdev);
>> +	dev->msi = !pci_enable_msi(dev->pdev);
>>  
>>  	dev->aac_msix[0].vector_no = 0;
>>  	dev->aac_msix[0].dev = dev;
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>