From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian King Subject: Re: [PATCH v4] cxlflash: Base support for IBM CXL Flash Adapter Date: Mon, 08 Jun 2015 16:45:58 -0500 Message-ID: <55760D16.1040203@linux.vnet.ibm.com> References: <1433540782-15276-1-git-send-email-mrochs@linux.vnet.ibm.com> <5575D6C6.5080808@linux.vnet.ibm.com> <55760BF2.4010408@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:34669 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753422AbbFHVqD (ORCPT ); Mon, 8 Jun 2015 17:46:03 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Jun 2015 15:46:03 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 93A873E4003E for ; Mon, 8 Jun 2015 15:46:01 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t58LhiB534078916 for ; Mon, 8 Jun 2015 14:43:44 -0700 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t58Lk0PG016485 for ; Mon, 8 Jun 2015 15:46:01 -0600 In-Reply-To: <55760BF2.4010408@linux.vnet.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: manoj@linux.vnet.ibm.com, "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James.Bottomley@HansenPartnership.com, nab@linux-iscsi.org, hch@infradead.org Cc: mikey@neuling.org, imunsie@au1.ibm.com On 06/08/2015 04:41 PM, Manoj Kumar wrote: > On 6/8/2015 12:54 PM, Brian King wrote: > >>> + >>> + rcr = send_tmf(afu, scp, TMF_LUN_RESET); >>> + if (unlikely(rcr)) >>> + rc = FAILED; >> >> Do you need to wait for all commands to the LUN to be returned before returning from >> here? You could put a simple loop here, polling until there are no ops outstanding >> to this LUN, if needed... > > Brian: > > Good suggestion. Would it be acceptable to add this capability in a future patch? That's fine with me. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center