linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Grover <agrover@redhat.com>
To: Hannes Reinecke <hare@suse.de>, Nic Bellinger <nab@daterainc.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/2] target: 64-bit LUN support
Date: Wed, 10 Jun 2015 09:45:17 -0700	[thread overview]
Message-ID: <5578699D.6090405@redhat.com> (raw)
In-Reply-To: <1433918483-46849-1-git-send-email-hare@suse.de>

On 06/09/2015 11:41 PM, Hannes Reinecke wrote:
> Hi Nic,
>
> here's now the patchset for making LIO-target support 64-bit LUNs.
> Pretty straightforward, plus an additional patch to remove the
> now obsolete limitation on 256 LUNs per TPG. There had been a
> comment in the header that REPORT LUN emulation would only support
> up to one page in payload, but I couldn't find any evidence for
> this in the code.
>
> As usual, comments and reviews are welcome.

Hi Hannes,

I think we also need to take care of how we report LUNs in spc.c 
spc_emulate_report_luns(). From reading SAM-5 4.7.7 (addressing methods) 
it looks like we're currently using the simple addressing format 
(address method = 0) and if we want to report more than 14 bits we would 
need to report the luns with a different addressing format.

I'm wondering if this could be seen as a bug in int_to_scsilun, but in 
any case I hope you'll take a look and make sure we're ok?

Thanks -- Regards -- Andy

  parent reply	other threads:[~2015-06-10 16:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  6:41 [PATCH 0/2] target: 64-bit LUN support Hannes Reinecke
2015-06-10  6:41 ` [PATCH 1/2] target: use 64-bit LUNs Hannes Reinecke
2015-06-10  6:41 ` [PATCH 2/2] target: Remove TARGET_MAX_LUNS_PER_TRANSPORT Hannes Reinecke
2015-06-10  8:07 ` [PATCH 0/2] target: 64-bit LUN support Nicholas A. Bellinger
2015-06-10 16:45 ` Andy Grover [this message]
2015-06-11  5:56   ` Hannes Reinecke
2015-06-11 14:38     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5578699D.6090405@redhat.com \
    --to=agrover@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@daterainc.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).