Re: [PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

[Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>]

On 06/16/2015 06:07 PM, Chris Leech wrote:
> The iSCSI session recovery_tmo setting is writeable in sysfs, but it's
> also set every time a connection is established when parameters are set
> from iscsid over netlink.  That results in the timeout being reset to
> the default value after every recovery.
> 
> The DM multipath tools want to use the sysfs interface to lower the
> default timeout when there are multiple paths to fail over.  It has
> caused confusion that we have a writeable sysfs value that seem to keep
> resetting itself.
> 
> This patch adds an in-kernel flag that gets set once a sysfs write
> occurs, and then ignores netlink parameter setting once it's been
> modified via the sysfs interface.  My thinking here is that the sysfs
> interface is much simpler for external tools to influence the session
> timeout, but if we're going to allow it to be modified directly we
> should ensure that setting is maintained.
> 

What happened? Why didn't you make it more generic so all future iscsi
sysfs settings work the same way like when I reviewed it in the bz? Did
it get too messy when we only have the one writeable attr?

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.