Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Minh Tran <minhduc.tran@avagotech.com>,
	linux-scsi@vger.kernel.org, sony.john@avagotech.com
Subject: Re: problem: connection teardown is always blocked because host is busy doing work on other connections
Date: Fri, 19 Jun 2015 01:16:52 -0500	[thread overview]
Message-ID: <5583B3D4.6040001@cs.wisc.edu> (raw)
In-Reply-To: <1434676188-2578-1-git-send-email-minh.tran@avagotech.com>

On 6/18/15, 8:09 PM, Minh Tran wrote:
> From: Minh Duc Tran <MinhDuc.Tran@avagotech.Com>
>
> This blocking is ok if we use software iscsi or iser where each
> connection has a separate host.  In the case of hw iscsi offload, one
> host could have hundreds of connections and some connections may have
> IOs running which makes host->host_busy is always TRUE.  Another
> problem is the host_lock taken here is disruptive to other
> connections' EH paths.  Wouldn't using target_busy a better choice
> here?
>

Do you talk to John :) I had told him to do that a couple days ago when 
you guys emailed me about this offlist.

However, I think Christoph wants to remove target_busy so you need to 
think of something else. I think you could take the session eh_mutex in 
the libiscsi session and conn teardown functions and rely on refcounting 
and state checks in the eh callouts.

  reply	other threads:[~2015-06-19  6:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19  1:09 problem: connection teardown is always blocked because host is busy doing work on other connections Minh Tran
2015-06-19  6:16 ` Mike Christie [this message]
2015-06-19  6:20   ` Minh Duc Tran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5583B3D4.6040001@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=linux-scsi@vger.kernel.org \
    --cc=minhduc.tran@avagotech.com \
    --cc=sony.john@avagotech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox