From: Hannes Reinecke <hare@suse.de>
To: "Seymour, Shane M" <shane.seymour@hp.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"James Bottomley (JBottomley@Odin.com)" <JBottomley@Odin.com>
Subject: Re: [PATCH] scsi_dh: convert __ATTR macro to DEVICE_ATTR_RW and snprintf show method cleanup
Date: Mon, 29 Jun 2015 13:40:03 +0200 [thread overview]
Message-ID: <55912E93.1000403@suse.de> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB3F8EAA39@G4W3219.americas.hpqcorp.net>
On 06/26/2015 08:38 AM, Seymour, Shane M wrote:
>
> Converted dh_state to use DEVICE_ATTR_RW macro
> instead of __ATTR. That forced a change to the associated
> show/store function names and the name of the attribute.
>
> Changed usage of snprintf in show function to scnprintf per
> Documentation/filesystems/sysfs.txt.
>
> Signed-off-by: Shane Seymour <shane.seymour@hp.com>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.de>
Note that I'm currently preparing a device handler update, based
upon an earlier patchset from hch.
I'll be folding this patch into it, unless it'll be picked up earlier.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-06-29 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 6:38 [PATCH] scsi_dh: convert __ATTR macro to DEVICE_ATTR_RW and snprintf show method cleanup Seymour, Shane M
2015-06-29 11:40 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55912E93.1000403@suse.de \
--to=hare@suse.de \
--cc=JBottomley@Odin.com \
--cc=linux-scsi@vger.kernel.org \
--cc=shane.seymour@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).