From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagig@mellanox.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 1/3] target: Inline transport_get_sense_codes()
Date: Mon, 6 Jul 2015 15:28:45 +0300 [thread overview]
Message-ID: <559A747D.7000404@dev.mellanox.co.il> (raw)
In-Reply-To: <20150706085958.GA15996@infradead.org>
On 7/6/2015 11:59 AM, Christoph Hellwig wrote:
> On Mon, Jul 06, 2015 at 11:02:25AM +0300, Sagi Grimberg wrote:
>> From: Bart Van Assche <bart.vanassche@sandisk.com>
>>
>> Inline this function in its call site since it performs a trivial
>> task and since it is only called once.
>>
>> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
>> Reviewed-by: Hannes Reinecke <hare@suse.de>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Sagi: if you send on Barts patches you probably should add your signoff
> as well.
I will. Thanks.
next prev parent reply other threads:[~2015-07-06 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 8:02 [PATCH v2 0/3] Target sense data handling modifications Sagi Grimberg
2015-07-06 8:02 ` [PATCH v2 1/3] target: Inline transport_get_sense_codes() Sagi Grimberg
2015-07-06 8:59 ` Christoph Hellwig
2015-07-06 12:28 ` Sagi Grimberg [this message]
2015-07-06 8:02 ` [PATCH v2 2/3] target: Split transport_send_check_condition_and_sense() Sagi Grimberg
2015-07-06 9:05 ` Christoph Hellwig
2015-07-06 8:02 ` [PATCH v2 3/3] target: Use scsi helpers to build the sense data correctly Sagi Grimberg
2015-07-06 9:06 ` Christoph Hellwig
2015-07-06 12:29 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A747D.7000404@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox