Re: [PATCH v2 3/3] target: Use scsi helpers to build the sense data correctly

Christoph Hellwig
2015-07-06T09:06:55Z

On Mon, Jul 06, 2015 at 11:02:27AM +0300, Sagi Grimberg wrote:
> Instead of open coding the sense buffer construction, use
> scsi scsi_build_sense_buffer() and scsi_set_sense_information()
> helpers which moved to scsi_common.
>
> This patch also fixes wrong setting of descriptor format sense data
> for t10-pi integrity errors.

Please split this into three patches:

1) move the helpers to scsi_common.c
2) use helpers in the target code
3) always use descriptor-type sense data for PI errors