From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH] SCSI-libcxgbi: Deletion of an unnecessary check before the function call "dst_release" Date: Thu, 9 Jul 2015 10:34:53 +0200 Message-ID: <559E322D.30705@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546EF5CC.1050308@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mout.web.de ([212.227.17.12]:56417 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbbGIIfD (ORCPT ); Thu, 9 Jul 2015 04:35:03 -0400 In-Reply-To: <546EF5CC.1050308@users.sourceforge.net> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall > From: Markus Elfring > Date: Fri, 21 Nov 2014 09:15:10 +0100 > > The dst_release() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/cxgbi/libcxgbi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > index addd1dd..95d2654 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -798,8 +798,7 @@ void cxgbi_sock_closed(struct cxgbi_sock *csk) > return; > if (csk->saddr.sin_port) > sock_put_port(csk); > - if (csk->dst) > - dst_release(csk->dst); > + dst_release(csk->dst); > csk->cdev->csk_release_offload_resources(csk); > cxgbi_sock_set_state(csk, CTP_CLOSED); > cxgbi_inform_iscsi_conn_closing(csk); > Would you like to integrate this update suggestion into another source code repository? Regards, Markus