From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Sagi Grimberg <sagig@mellanox.com>, linux-scsi@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi: Fix sense information setting in fixed sized format
Date: Thu, 9 Jul 2015 07:38:07 -0700 [thread overview]
Message-ID: <559E874F.5080105@sandisk.com> (raw)
In-Reply-To: <1436367603-16456-1-git-send-email-sagig@mellanox.com>
On 07/08/15 08:00, Sagi Grimberg wrote:
> In fixed size sense format the information field is a four byte
> field.
>
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> ---
> drivers/scsi/scsi_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c
> index 41432c1..8cfb7ee 100644
> --- a/drivers/scsi/scsi_common.c
> +++ b/drivers/scsi/scsi_common.c
> @@ -270,7 +270,7 @@ void scsi_set_sense_information(u8 *buf, u64 info)
> put_unaligned_be64(info, &ucp[4]);
> } else if ((buf[0] & 0x7f) == 0x70) {
> buf[0] |= 0x80;
> - put_unaligned_be64(info, &buf[3]);
> + put_unaligned_be32(info, &buf[3]);
> }
> }
> EXPORT_SYMBOL(scsi_set_sense_information);
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2015-07-09 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 15:00 [PATCH] scsi: Fix sense information setting in fixed sized format Sagi Grimberg
2015-07-09 14:38 ` Bart Van Assche [this message]
2015-07-09 16:27 ` Martin K. Petersen
2015-07-11 11:27 ` Christoph Hellwig
2015-07-12 6:36 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E874F.5080105@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagig@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox