From: Hannes Reinecke <hare@suse.de>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>,
Sagi Grimberg <sagig@mellanox.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common
Date: Fri, 10 Jul 2015 08:39:39 +0200 [thread overview]
Message-ID: <559F68AB.8020401@suse.de> (raw)
In-Reply-To: <559D4071.8010501@dev.mellanox.co.il>
On 07/08/2015 05:23 PM, Sagi Grimberg wrote:
> On 7/8/2015 6:06 PM, Hannes Reinecke wrote:
>
>> We're adding extra fields here, so we need to make sure to not
>> overflow the buffer. You probably have to pass in the buffersize
>> to avoid an overflow ...
>> Yeah, I know, it's theoretical at the moment.
>> But there's nothing which prevents anyone to add other fields to it,
>> so this field might be the one causing the overflow.
>
> Since this patch is simply a movement of functions I don't think I
> should change any functionality here. Would it be acceptable to fix
> this in an incremental patch?
Sure.
So you can add a
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-10 6:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 14:58 [PATCH v4 0/5] Target sense data handling modifications Sagi Grimberg
2015-07-08 14:58 ` [PATCH v4 1/5] target: Inline transport_get_sense_codes() Sagi Grimberg
2015-07-09 16:13 ` Martin K. Petersen
2015-07-08 14:58 ` [PATCH v4 2/5] target: Split transport_send_check_condition_and_sense() Sagi Grimberg
2015-07-09 16:15 ` Martin K. Petersen
2015-07-08 14:58 ` [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common Sagi Grimberg
2015-07-08 15:06 ` Hannes Reinecke
2015-07-08 15:23 ` Sagi Grimberg
2015-07-10 6:39 ` Hannes Reinecke [this message]
2015-07-09 16:16 ` Martin K. Petersen
2015-07-08 14:58 ` [PATCH v4 4/5] target: Use scsi helpers to build the sense data correctly Sagi Grimberg
2015-07-08 15:07 ` Hannes Reinecke
2015-07-09 16:17 ` Martin K. Petersen
2015-07-08 14:58 ` [PATCH v4 5/5] target: Return ABORTED_COMMAND sense key for PI errors Sagi Grimberg
2015-07-08 15:07 ` Hannes Reinecke
2015-07-09 16:21 ` Martin K. Petersen
2015-07-24 5:16 ` [PATCH v4 0/5] Target sense data handling modifications Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559F68AB.8020401@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@dev.mellanox.co.il \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).