From: Jens Axboe <axboe@fb.com>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface
Date: Tue, 14 Jul 2015 08:04:19 -0600 [thread overview]
Message-ID: <55A516E3.8040708@fb.com> (raw)
In-Reply-To: <55A4F0FD.6070305@suse.de>
On 07/14/2015 05:22 AM, Hannes Reinecke wrote:
> On 07/14/2015 09:13 AM, Christoph Hellwig wrote:
>> Looks good:
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>
>> I wonder if we should start to gradually phase out these tuables in the
>> host template. It's not really more complicated to set them directly
>> in the host anyway.
>
> Fully agreed. I would vote for making the host template read-only
> and modify all drivers to use the shost setting.
Indeed, that would be a much saner choice. The settings in a
(effectively already) read-only host template seems like somewhat of a
relic.
--
Jens Axboe
next prev parent reply other threads:[~2015-07-14 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 14:24 [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface Jens Axboe
2015-07-14 1:30 ` Martin K. Petersen
2015-07-14 7:13 ` Christoph Hellwig
2015-07-14 11:22 ` Hannes Reinecke
2015-07-14 14:04 ` Jens Axboe [this message]
2015-07-14 14:14 ` Hannes Reinecke
2015-07-14 14:20 ` Martin K. Petersen
2015-07-14 14:32 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A516E3.8040708@fb.com \
--to=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox