From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface
Date: Tue, 14 Jul 2015 16:32:00 +0200 [thread overview]
Message-ID: <55A51D60.9010600@suse.de> (raw)
In-Reply-To: <yq1mvyystwh.fsf@sermon.lab.mkp.net>
On 07/14/2015 04:20 PM, Martin K. Petersen wrote:
>>>>>> "Jens" == Jens Axboe <axboe@fb.com> writes:
>
>>> Fully agreed. I would vote for making the host template read-only and
>>> modify all drivers to use the shost setting.
>
> Jens> Indeed, that would be a much saner choice. The settings in a
> Jens> (effectively already) read-only host template seems like somewhat
> Jens> of a relic.
>
> Agree 100%.
>
While we're at it: why is the 'cmd_pool' attached to the host
template? Do all hosts with the same driver share a common pool?
(I sincerely do hope not ...)
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-07-14 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 14:24 [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface Jens Axboe
2015-07-14 1:30 ` Martin K. Petersen
2015-07-14 7:13 ` Christoph Hellwig
2015-07-14 11:22 ` Hannes Reinecke
2015-07-14 14:04 ` Jens Axboe
2015-07-14 14:14 ` Hannes Reinecke
2015-07-14 14:20 ` Martin K. Petersen
2015-07-14 14:32 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A51D60.9010600@suse.de \
--to=hare@suse.de \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox