From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Sagi Grimberg <sagig@mellanox.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH v1 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors
Date: Wed, 15 Jul 2015 07:07:59 -0700 [thread overview]
Message-ID: <55A6693F.5010807@sandisk.com> (raw)
In-Reply-To: <1436946939-19415-4-git-send-email-sagig@mellanox.com>
On 07/15/15 00:55, Sagi Grimberg wrote:
> +bool target_sense_desc_format(struct se_device *dev)
> +{
> + return dev->transport->get_blocks(dev) > 0xffffffffULL;
> +}
Please consider to use U32_MAX instead of 0xffffffffULL since that would
make this function easier to read and to verify.
Bart.
next prev parent reply other threads:[~2015-07-15 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 7:55 [PATCH v1 0/4] Descriptor format sense data Sagi Grimberg
2015-07-15 7:55 ` [PATCH v1 1/4] scsi: Fix wrong additional sense length in descriptor format Sagi Grimberg
2015-07-15 8:27 ` Christoph Hellwig
2015-07-15 7:55 ` [PATCH v1 2/4] scsi: Protect against buffer possible overflow in scsi_set_sense_information Sagi Grimberg
2015-07-15 8:29 ` Christoph Hellwig
2015-07-15 7:55 ` [PATCH v1 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors Sagi Grimberg
2015-07-15 8:06 ` Hannes Reinecke
2015-07-15 8:29 ` Christoph Hellwig
2015-07-15 14:07 ` Bart Van Assche [this message]
2015-07-16 0:34 ` Martin K. Petersen
2015-07-15 7:55 ` [PATCH v1 4/4] libiscsi: Use scsi helper to set information descriptor Sagi Grimberg
2015-07-15 8:07 ` Hannes Reinecke
2015-07-15 8:30 ` Christoph Hellwig
2015-07-16 0:33 ` Martin K. Petersen
2015-07-24 5:59 ` [PATCH v1 0/4] Descriptor format sense data Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A6693F.5010807@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox