From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH 06/11] hpsa: cleanup update scsi devices Date: Wed, 22 Jul 2015 17:19:07 +0200 Message-ID: <55AFB46B.7050805@redhat.com> References: <20150718160245.31955.16794.stgit@brunhilda> <20150718161249.31955.25688.stgit@brunhilda> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36863 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934322AbbGVPTK (ORCPT ); Wed, 22 Jul 2015 11:19:10 -0400 In-Reply-To: <20150718161249.31955.25688.stgit@brunhilda> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Don Brace , scott.teel@pmcs.com, Kevin.Barnett@pmcs.com, james.bottomley@parallels.com, hch@infradead.org, Justin.Lindley@pmcs.com, elliott@hp.com Cc: linux-scsi@vger.kernel.org On 18.7.2015 18:12, Don Brace wrote: > showing that tables have been updated unnecessarily. > > Reviewed-by: Kevin Barnett > Reviewed-by: Scott Teel > Signed-off-by: Don Brace Reviewed-by: Tomas Henzl Tomas > --- > drivers/scsi/hpsa.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index f64a2c7..f34978d 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -1379,8 +1379,9 @@ static inline int device_updated(struct hpsa_scsi_dev_t *dev1, > return 1; > if (dev1->offload_enabled != dev2->offload_enabled) > return 1; > - if (dev1->queue_depth != dev2->queue_depth) > - return 1; > + if (!is_logical_dev_addr_mode(dev1->scsi3addr)) > + if (dev1->queue_depth != dev2->queue_depth) > + return 1; > return 0; > } > > @@ -3889,7 +3890,6 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h, int hostno) > else if (!(h->transMethod & CFGTBL_Trans_io_accel1 || > h->transMethod & CFGTBL_Trans_io_accel2)) > break; > - > hpsa_get_ioaccel_drive_info(h, this_device, > lunaddrbytes, id_phys); > hpsa_get_path_info(this_device, lunaddrbytes, id_phys); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >