From: James Smart <james.smart@avagotech.com>
To: Sebastian Herbszt <herbszt@gmx.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] lpfc: Use && instead of & for boolean expression
Date: Wed, 22 Jul 2015 11:47:20 -0400 [thread overview]
Message-ID: <55AFBB08.106@avagotech.com> (raw)
In-Reply-To: <20150722105322.00004f4b@localhost>
Reviewed-by: James Smart <james.smart@avagotech.com>
Thanks
-- james
On 7/22/2015 4:53 AM, Sebastian Herbszt wrote:
> Use logical instead of bitwise AND.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> ---
>
> diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-05 22:18:43.933739150 +0200
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-22 10:31:14.240209475 +0200
> @@ -701,7 +701,7 @@ lpfc_work_done(struct lpfc_hba *phba)
> HA_RXMASK));
> }
> }
> - if ((phba->sli_rev == LPFC_SLI_REV4) &
> + if ((phba->sli_rev == LPFC_SLI_REV4) &&
> (!list_empty(&pring->txq)))
> lpfc_drain_txq(phba);
> /*
prev parent reply other threads:[~2015-07-22 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 8:53 [PATCH] lpfc: Use && instead of & for boolean expression Sebastian Herbszt
2015-07-22 15:47 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AFBB08.106@avagotech.com \
--to=james.smart@avagotech.com \
--cc=herbszt@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox