* [PATCH] lpfc: Use && instead of & for boolean expression
@ 2015-07-22 8:53 Sebastian Herbszt
2015-07-22 15:47 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Herbszt @ 2015-07-22 8:53 UTC (permalink / raw)
To: linux-scsi; +Cc: James Smart, Sebastian Herbszt
Use logical instead of bitwise AND.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
---
diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-05 22:18:43.933739150 +0200
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-22 10:31:14.240209475 +0200
@@ -701,7 +701,7 @@ lpfc_work_done(struct lpfc_hba *phba)
HA_RXMASK));
}
}
- if ((phba->sli_rev == LPFC_SLI_REV4) &
+ if ((phba->sli_rev == LPFC_SLI_REV4) &&
(!list_empty(&pring->txq)))
lpfc_drain_txq(phba);
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lpfc: Use && instead of & for boolean expression
2015-07-22 8:53 [PATCH] lpfc: Use && instead of & for boolean expression Sebastian Herbszt
@ 2015-07-22 15:47 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2015-07-22 15:47 UTC (permalink / raw)
To: Sebastian Herbszt, linux-scsi
Reviewed-by: James Smart <james.smart@avagotech.com>
Thanks
-- james
On 7/22/2015 4:53 AM, Sebastian Herbszt wrote:
> Use logical instead of bitwise AND.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> ---
>
> diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-05 22:18:43.933739150 +0200
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-22 10:31:14.240209475 +0200
> @@ -701,7 +701,7 @@ lpfc_work_done(struct lpfc_hba *phba)
> HA_RXMASK));
> }
> }
> - if ((phba->sli_rev == LPFC_SLI_REV4) &
> + if ((phba->sli_rev == LPFC_SLI_REV4) &&
> (!list_empty(&pring->txq)))
> lpfc_drain_txq(phba);
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-22 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 8:53 [PATCH] lpfc: Use && instead of & for boolean expression Sebastian Herbszt
2015-07-22 15:47 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox