From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Spencer Baugh <sbaugh@catern.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
"open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"open list:TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Joern Engel <joern@purestorage.com>,
Spencer Baugh <Spencer.baugh@purestorage.com>
Subject: Re: [PATCH] target: improve unsupported opcode message
Date: Thu, 23 Jul 2015 12:57:07 +0300 [thread overview]
Message-ID: <55B0BA73.8010402@dev.mellanox.co.il> (raw)
In-Reply-To: <1437602500-3793-1-git-send-email-sbaugh@catern.com>
On 7/23/2015 1:01 AM, Spencer Baugh wrote:
> From: Joern Engel <joern@purestorage.com>
>
> Make the warning about unsupported SCSI opcode more useful:
>
> - Add in the initiator name so we know who's sending it.
> - Print the warning even for opcodes that spc_parse_cdb() knows about
> but that we don't handle.
>
> Signed-off-by: Joern Engel <joern@purestorage.com>
> Signed-off-by: Spencer Baugh <sbaugh@catern.com>
Looks good,
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
next prev parent reply other threads:[~2015-07-23 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 22:01 [PATCH] target: improve unsupported opcode message Spencer Baugh
2015-07-23 9:39 ` Christoph Hellwig
2015-07-23 9:57 ` Sagi Grimberg [this message]
2015-07-31 6:46 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0BA73.8010402@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=Spencer.baugh@purestorage.com \
--cc=joern@purestorage.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sbaugh@catern.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox