From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH] target: improve unsupported opcode message Date: Thu, 23 Jul 2015 12:57:07 +0300 Message-ID: <55B0BA73.8010402@dev.mellanox.co.il> References: <1437602500-3793-1-git-send-email-sbaugh@catern.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f172.google.com ([209.85.212.172]:36565 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbbGWJ5I (ORCPT ); Thu, 23 Jul 2015 05:57:08 -0400 Received: by wicgb10 with SMTP id gb10so135190819wic.1 for ; Thu, 23 Jul 2015 02:57:07 -0700 (PDT) In-Reply-To: <1437602500-3793-1-git-send-email-sbaugh@catern.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Spencer Baugh , "Nicholas A. Bellinger" , "open list:TARGET SUBSYSTEM" , "open list:TARGET SUBSYSTEM" , open list Cc: Joern Engel , Spencer Baugh On 7/23/2015 1:01 AM, Spencer Baugh wrote: > From: Joern Engel > > Make the warning about unsupported SCSI opcode more useful: > > - Add in the initiator name so we know who's sending it. > - Print the warning even for opcodes that spc_parse_cdb() knows about > but that we don't handle. > > Signed-off-by: Joern Engel > Signed-off-by: Spencer Baugh Looks good, Reviewed-by: Sagi Grimberg