public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Tomas Henzl <thenzl@redhat.com>
To: rajinikanth.pandurangan@pmcs.com, jbottomley@parallels.com,
	linux-scsi@vger.kernel.org
Cc: aacraid@pmc-sierra.com, harry.yang@pmcs.com, rich.bono@pmcs.com,
	mahesh.rajashekhara@pmcs.com, achim.leubner@pmcs.com,
	murthy.bhat@pmcs.com
Subject: Re: [PATCH V5 03/11] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller
Date: Thu, 23 Jul 2015 16:38:39 +0200	[thread overview]
Message-ID: <55B0FC6F.2020506@redhat.com> (raw)
In-Reply-To: <1437583757-5449-4-git-send-email-rajinikanth.pandurangan@pmcs.com>

On 22.7.2015 18:49, rajinikanth.pandurangan@pmcs.com wrote:
> From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
> 
> Description:
>         This change always sets MSI interrupt mode for series-6 controller.
> Note: For series 6 family, MSIx is not supported.
> 
> Changes from V2:
> Only Subject & description change.
> 
> Reviewed by:
>  Tomas Henzl <thenzl@redhat.com>,
I haven't noticed this before, but in V2 I haven't reviewed
this patch, I have asked you for a change which hasn't
been followed.
Please remove my 'Reviewed by' tag.
-tm


>  Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>,
>  Johannes Thumshirn <jthumshirn@suse.de>
> 
> Signed-off-by: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
> ---
>  drivers/scsi/aacraid/src.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
> index b147341..eb07b3d 100644
> --- a/drivers/scsi/aacraid/src.c
> +++ b/drivers/scsi/aacraid/src.c
> @@ -742,7 +742,7 @@ int aac_src_init(struct aac_dev *dev)
>  	if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE1)
>  		goto error_iounmap;
>  
> -	dev->msi = aac_msi && !pci_enable_msi(dev->pdev);
> +	dev->msi = !pci_enable_msi(dev->pdev);
>  
>  	dev->aac_msix[0].vector_no = 0;
>  	dev->aac_msix[0].dev = dev;
> 


  reply	other threads:[~2015-07-23 14:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 16:49 [PATCH V5 00/11] [SCSI] aacraid: Patchset for aacraid driver version 41010 rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 01/11] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 02/11] [SCSI] aacraid: Add Power Management support rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 03/11] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller rajinikanth.pandurangan
2015-07-23 14:38   ` Tomas Henzl [this message]
2015-07-22 16:49 ` [PATCH V5 04/11] [SCSI] aacraid: Enable 64-bit write to controller register rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 05/11] [SCSI] aacraid: Tune response path if IsFastPath bit set rajinikanth.pandurangan
2015-07-23 14:39   ` Tomas Henzl
2015-07-23 18:41     ` Rajinikanth Pandurangan
2015-07-22 16:49 ` [PATCH V5 06/11] [SCSI] aacraid: Reset irq affinity hints before releasing irq rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 07/11] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 08/11] [SCSI] aacraid: Send commit-config to controller firmware rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 09/11] [SCSI] aacraid: Update driver version rajinikanth.pandurangan
2015-07-22 16:49 ` [PATCH V5 10/11] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range() rajinikanth.pandurangan
2015-07-23 12:54   ` Tomas Henzl
2015-07-23 13:42     ` Rajinikanth Pandurangan
2015-07-23 14:33       ` Tomas Henzl
2015-07-23 18:39         ` Rajinikanth Pandurangan
2015-08-11  6:01         ` Mahesh Rajashekhara
     [not found]     ` <7000_1437658952_55B0EF48_7000_4689_1_E34C6B6293F0214497D0C55B92526C05EAFF8421@BBYEXM02.pmc-sierra.internal>
2015-07-23 13:52       ` Rajinikanth Pandurangan
2015-07-22 16:49 ` [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range() rajinikanth.pandurangan
2015-07-23 12:55   ` Tomas Henzl
2015-08-12 18:29     ` James Bottomley
2015-08-12 18:56       ` Harry Yang
2015-08-13  0:22       ` Mahesh Rajashekhara
2015-08-17 14:12         ` Mahesh Rajashekhara
2015-08-17 14:17           ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B0FC6F.2020506@redhat.com \
    --to=thenzl@redhat.com \
    --cc=aacraid@pmc-sierra.com \
    --cc=achim.leubner@pmcs.com \
    --cc=harry.yang@pmcs.com \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mahesh.rajashekhara@pmcs.com \
    --cc=murthy.bhat@pmcs.com \
    --cc=rajinikanth.pandurangan@pmcs.com \
    --cc=rich.bono@pmcs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox