Re: [PATCH V5 03/11] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller

Tomas Henzl
2015-07-23T14:38:42Z

On 22.7.2015 18:49, rajinikanth.pandurangan@pmcs.com wrote:
> From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
>
> Description:
> This change always sets MSI interrupt mode for series-6 controller.
> Note: For series 6 family, MSIx is not supported.
>
> Changes from V2:
> Only Subject & description change.
>
> Reviewed by:
> Tomas Henzl <thenzl@redhat.com>,
I haven't noticed this before, but in V2 I haven't reviewed
this patch, I have asked you for a change which hasn't
been followed.
Please remove my 'Reviewed by' tag.
-tm

> Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>,
> Johannes Thumshirn <jthumshirn@suse.de>
>
> Signed-off-by: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
> ---
> drivers/scsi/aacraid/src.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
> index b147341..eb07b3d 100644
> --- a/drivers/scsi/aacraid/src.c
> +++ b/drivers/scsi/aacraid/src.c
> @@ -742,7 +742,7 @@ int aac_src_init(struct aac_dev *dev)
> if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE1)
> goto error_iounmap;
>
> - dev->msi = aac_msi && !pci_enable_msi(dev->pdev);
> + dev->msi = !pci_enable_msi(dev->pdev);
>
> dev->aac_msix[0].vector_no = 0;
> dev->aac_msix[0].dev = dev;
>