From: Manoj Kumar <manoj@linux.vnet.ibm.com>
To: wenxiong@linux.vnet.ibm.com, mrochs@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org,
James.Bottomley@hansenpartnership.com, nab@linux-iscsi.org,
brking@linux.vnet.ibm.com
Cc: hch@infradead.org, mikey@neuling.org, imunsie@au1.ibm.com,
dja@ozlabs.au.ibm.com
Subject: Re: [PATCH v2 1/3] cxlflash: Base error recovery support
Date: Thu, 30 Jul 2015 18:04:28 -0500 [thread overview]
Message-ID: <55BAAD7C.9020008@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150729181253.Horde.skEaoxQBlFsVmLXOtcyLAw7@ltc.linux.ibm.com>
Wendy:
Thanks for your review. Comment inline below.
- Manoj Kumar
On 7/29/2015 5:12 PM, wenxiong@linux.vnet.ibm.com wrote:
>> +
>> + cfg->eeh_active = EEH_STATE_NONE;
>> + wake_up_all(&cfg->eeh_waitq);
>> +}
>> +
>
> Do you need host->lock in these EEH callback functions?
These are synchronous callbacks and only one of them can be active on a
card at a time. So, I do not believe these need the host->lock.
prev parent reply other threads:[~2015-07-30 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 23:26 [PATCH v2 1/3] cxlflash: Base error recovery support Matthew R. Ochs
[not found] ` <55B13A99.7030603@linux.vnet.ibm.com>
2015-07-29 22:12 ` wenxiong
2015-07-30 23:04 ` Manoj Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BAAD7C.9020008@linux.vnet.ibm.com \
--to=manoj@linux.vnet.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=dja@ozlabs.au.ibm.com \
--cc=hch@infradead.org \
--cc=imunsie@au1.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=mrochs@linux.vnet.ibm.com \
--cc=nab@linux-iscsi.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).