From: Maurizio Lombardi <mlombard@redhat.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-scsi@vger.kernel.org, hiralpat@cisco.com,
sramars@cisco.com, buchino@cisco.com, jbottomley@parallels.com
Subject: Re: [PATCH] fnic: check pci_map_single() return value
Date: Wed, 12 Aug 2015 13:56:40 +0200 [thread overview]
Message-ID: <55CB3478.7060200@redhat.com> (raw)
In-Reply-To: <mqdr3n8ybqt.fsf@c203.arch.suse.de>
Hi Johannes,
On 08/12/2015 01:42 PM, Johannes Thumshirn wrote:
> hmmm, how about
>
> goto free_skb;
>> + }
>> +
>> fnic_queue_rq_desc(rq, skb, pa, len);
>> - return 0;
>> +err:
>
> free_skb:
> kfree_skb(skb);
>
>> + return r;
>> }
>
> Although the return is near to the error handling, it's preferred to
> have the labels named after the action that is taken there.
Ok, I'll post a V2 of this patch soon, thanks for the review.
Regards,
Maurizio Lombardi
prev parent reply other threads:[~2015-08-12 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 9:20 [PATCH] fnic: check pci_map_single() return value Maurizio Lombardi
2015-08-12 11:42 ` Johannes Thumshirn
2015-08-12 11:56 ` Maurizio Lombardi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB3478.7060200@redhat.com \
--to=mlombard@redhat.com \
--cc=buchino@cisco.com \
--cc=hiralpat@cisco.com \
--cc=jbottomley@parallels.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=sramars@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).